git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] submodule: make 'show' an alias for 'summary'

From
Jens Lehmann <jens.lehmann@web.de>
Date
Oct 1, 2012, 19:31 UTC
Message-ID
<5069EFAA.4090305@web.de>
In-Reply-To
<CALkWK0mQMe1zfbPNf5prjgTwFtPKJuK=uwxqAqN_Q2=76e-=mA@mail.gmail.com>
Am 01.10.2012 19:33, schrieb Ramkumar Ramachandra:
Show 20 quoted lines
> Jens Lehmann wrote:
>> Am 01.10.2012 08:45, schrieb Ramkumar Ramachandra:
>>> Jens Lehmann wrote:
>>>> I'm very interested in your feedback as a first time submodule user,
>>>> what you wrote above makes sense and explains why you did that patch
>>>> (and it would have been nice to read some of it in the commit message
>>>> ;-). What information did you expect to get from a "git submodule
>>>> show" which isn't already provided by "git status" and "git diff"
>>>> (especially as they give you some information the "git submodule"
>>>> commands don't)?
>>>
>>> I expected 'git submodule show' to list all the submodules, and show
>>> changes to specific submodules like the 'git submodule summary'
>>> output.
>>
>> Ok, but "git submodule summary" doesn't list all the submodules,
>> only those with changes. Maybe "git submodule status" is closer
>> to what you expect (except for the missing changes)?
> 
> Yes, "git submodule status" with "git submodule summary"-style change output.

So just aliasing "show" to "summary" would not have done the trick, right? ;-)

Show 10 quoted lines
>> And - apart from the list of all submodules - the changes to them
>> are given by "git status" and "git diff --submodule" too, right?
> 
> Oh, I didn't know about "git diff --submodule" at all.
> 
>> (sometimes I forget that "--submodule" is not enabled by default,
>> as I'm a heavy "git gui" user, and that option is used there. We
>> might need a config option to turn that on)
> 
> That's a good idea.  I'll write a patch tomorrow.

Cool! I suspect showing the difference in shortlog style is much more useful than seeing the hashes.

Show 7 quoted lines
>> Me too would expect a show command to show me a list of all the
>> submodules and maybe some extra information (is it populated or
>> not, does it have its .git directory embedded, does it contain
>> changes). So maybe "show" should be a slightly pimped "status"?
> 
> Sure.  Do we want to create a new subcommand though?  Aren't "status"
> and "summary" enough already?

Yes, I don't think we need a new command. Maybe someday we will change "git submodule status" to contain less hash and maybe some other infos, but we're not there yet.

Previous: Ramkumar RamachandraNext: Junio C Hamano
Message 14 of 15 in “submodule: make 'show' an alias for 'summary'”
  1. submodule: make 'show' an alias for 'summary'Ramkumar Ramachandra, Sep 29, 2012
  2. submodule: use abbreviated sha1 in 'status' outputRamkumar Ramachandra, Sep 29, 2012
  3. Jens LehmannSep 29, 2012
  4. Ramkumar RamachandraSep 29, 2012
  5. Jens LehmannSep 29, 2012
  6. Ramkumar RamachandraOct 1, 2012
  7. Jens LehmannOct 1, 2012
  8. Jens LehmannSep 29, 2012
  9. Ramkumar RamachandraSep 29, 2012
  10. Jens LehmannSep 29, 2012
  11. Ramkumar RamachandraOct 1, 2012
  12. Jens LehmannOct 1, 2012
  13. Ramkumar RamachandraOct 1, 2012
  14. Jens LehmannOct 1, 2012
  15. Junio C HamanoOct 1, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.