git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] build: don't duplicate substitution of make variables

From
Stefano Lattarini <stefano.lattarini@gmail.com>
Date
Sep 11, 2012, 20:17 UTC
Message-ID
<504F9C73.1040409@gmail.com>
In-Reply-To
<7vd31sgww4.fsf@alter.siamese.dyndns.org>
On 09/11/2012 09:52 PM, Junio C Hamano wrote:
Show 16 quoted lines
> Stefano Lattarini <stefano.lattarini@gmail.com> writes:
> 
>> On 09/11/2012 07:27 PM, Junio C Hamano wrote:
>>
>>> These two hunks suggest that you may be favoring spaces, but other
>>> places you seem to use tabs, so...
>>>
>> I can convert the new tabs to spaces if you prefer (that would have been
>> my preference too, but thought trying to follow the "Git preferences"
>> was more important).  No big deal either way for me.
> 
> If this were other parts of the system, my preference would be to
> use tabs, but because I do not help very much in the autoconf part
> myself, I do not have a particular preference.  If it is more common
> to indent the configure.ac script with spaces,
>

There is no general standard about it that I know of; it's just that GNU projects tend to prefer space-based indentation over tab-based one, and since I mostly touch configure.ac files from GNU projects, I've picked up the habit.

Show 5 quoted lines
> that would be more
> familiar to the folks who work on it, and I do not have much against
> choosing and sticking to space indented configure.ac file if that is
> the policy.
>

Then I might send a patch that normalize indentation in configure.ac to "spaces only", if that's OK with you. But that's obviously for a separated thread.

> But if this patch is not about cleaning up the style to make it
> conform to a policy (whichever it is), I would have preferred to see
> a clean-up patch as a separate step, not mixed together with this.
>

The reason those few clean-ups are mixed into this patch is that the pre-existing strange indentation style was actually making it more difficult for me to grasp the code flow; that is, I didn't see them as a cosmetic change, but as a way to make it easier for me and the reader to see that my changes were correct and sensible.

> That's all; either way, no big deal.
>

OK. Just let me know if you'd still prefer to have the indentation cleanups done by a preparatory patch, and I'll send a re-roll.

Thanks,
  Stefano
Previous: Junio C Hamano
Message 6 of 6 in “build: improve GIT_CONF_SUBST signature”
  1. 1/2 build: improve GIT_CONF_SUBST signatureStefano Lattarini, Sep 11, 2012
  2. 2/2 build: don't duplicate substitution of make variablesStefano Lattarini, Sep 11, 2012
  3. Junio C HamanoSep 11, 2012
  4. Stefano LattariniSep 11, 2012
  5. Junio C HamanoSep 11, 2012
  6. Stefano LattariniSep 11, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.