Re: What's cooking in git.git (Sep 2012, #02; Fri, 7)
- From
Torsten Bögershausen <tboegi@web.de>
- Date
- Sep 8, 2012, 05:47 UTC
- Message-ID
- <504ADBEA.1050606@web.de>
- In-Reply-To
- <7vy5klv6oj.fsf@alter.siamese.dyndns.org>
On 07.09.12 23:55, Junio C Hamano wrote:
Show 9 quoted lines
> [Discarded] > > * jc/sanitize-nkd-lazy-iconv-open (2012-07-31) 1 commit > . macos: lazily initialize iconv > > Teach the code that works around NKD/NKC gotcha on MacOS to call > iconv_open() only when it is necessary, in the hope of avoiding > set-up overhead. It turns out that there was no noticeable > improvements.
My vote is not to discard the branch:
Even if the improvements are not measurable, the lazy iconv_open is a good coding style.
It might inspire people to use resources carefully, and only allocate them if they are really needed.