Re: poll() emulation in git
Il 06/09/2012 16:44, Joachim Schmitz ha scritto:
Show 14 quoted lines
>> > Yes, it's an usleep(autocorrect * 100000) basically (poll takes
>> > milliseconds, not micro).
> OK, it is _supposed_ to do this usleep(), but is does not, as poll() returns early with EFAULT in this case:
> /* EFAULT is not necessary to implement, but let's do it in the
> simplest case. */
> if (!pfd)
> {
> errno = EFAULT;
> return -1;
> }
>
> poll() is doing this before calling select(), so won't sleep.
> So there's a bug in {gnulib|git}'s poll(), right?
> Yes, it should be "if (!pfd && nfd)".
Paolo