[PATCH 2/5] path.c: Don't discard the return value of vsnpath()
- From
Ramsay Jones <ramsay@ramsay1.demon.co.uk>
- Date
- Sep 4, 2012, 17:27 UTC
- Message-ID
- <50463A1A.9000801@ramsay1.demon.co.uk>
The git_snpath() and git_pathdup() functions both use the (static) function vsnpath() in their implementation. Also, they both discard the return value of vsnpath(), which has the effect of ignoring the side effect of calling cleanup_path() in the non-error return path.
In order to ensure that the required cleanup happens, we use the pointer returned by vsnpath(), rather than the buffer passed into vsnpath(), to derive the return value from git_snpath() and git_pathdup().
Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk> --- path.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/path.c b/path.c index 9eb5333..741ae77 100644 --- a/path.c +++ b/path.c @@ -70,21 +70,22 @@ bad: char *git_snpath(char *buf, size_t n, const char *fmt, ...) { + char *ret; va_list args; va_start(args, fmt); - (void)vsnpath(buf, n, fmt, args); + ret = vsnpath(buf, n, fmt, args); va_end(args); - return buf; + return ret; } char *git_pathdup(const char *fmt, ...) { - char path[PATH_MAX]; + char path[PATH_MAX], *ret; va_list args; va_start(args, fmt); - (void)vsnpath(path, sizeof(path), fmt, args); + ret = vsnpath(path, sizeof(path), fmt, args); va_end(args); - return xstrdup(path); + return xstrdup(ret); } char *mkpathdup(const char *fmt, ...)
-- 1.7.12