git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Additional changes

From
Jean-Noël AVILA <jn.avila@free.fr>
Date
May 9, 2025, 12:12 UTC
Message-ID
<5040970.31r3eYUQgx@cayenne>
In-Reply-To
<xmqq1psz878f.fsf@gitster.g>
On Thursday, 8 May 2025 17:14:40 CEST Junio C Hamano wrote:
Show 26 quoted lines
> Jean-Noël Avila <jn.avila@free.fr> writes:
> > ---
> > 
> >  Documentation/git-daemon.adoc     | 60 +++++++++++++++----------------
> >  Documentation/git-var.adoc        | 40 ++++++++++-----------
> >  Documentation/git-verify-tag.adoc |  2 +-
> >  Documentation/git-write-tree.adoc |  2 +-
> >  4 files changed, 51 insertions(+), 53 deletions(-)
> 
> I was somewhat confused where this patch is designed to apply, but I
> think I figured it out.  These are to further update on top of my
> synopsis related mark-up updates.
> 
> Do you mean this as a set of review comment, i.e. I am expected to
> spilt them into parts and fold them into those three commits to
> produce an updated version of those three patches with "Helped-by:"
> attributing you?
> 
> Or do you want this to sit on top of the 3-patch series separately
> as the 4th patch?  If the latter we'd need a log message plus
> sign-off.
> 
> I'd assume it is the former (as the three-patch series hasn't hit
> 'next' yet) and start updating htese three patches.
> 
> Thanks.

Sorry for not being clear. I was wary of what the provided patches did not address, so I reviewed after applying your series and bundled it in another patch, which was not signed off on purpose.

Of course, the proposed changes can be discussed. If you prefer, I can dispatch them and propose a v3.

Thanks,
JN
Previous: Junio C HamanoNext: Junio C Hamano
Message 18 of 26 in “A handful of doc synopsis/options update”
  1. 0/4 A handful of doc synopsis/options updateJunio C Hamano, May 1, 2025
  2. 1/4 git-verify-* doc: update mark-up of synopsis option descriptionsJunio C Hamano, May 1, 2025
  3. Eric SunshineMay 1, 2025
  4. Junio C HamanoMay 1, 2025
  5. 2/4 git-{var,write-tree} docs: update mark-up of synopsis option descriptionsJunio C Hamano, May 1, 2025
  6. 3/4 git-daemon doc: update mark-up of synopsis option descriptionsJunio C Hamano, May 1, 2025
  7. Eric SunshineMay 1, 2025
  8. Junio C HamanoMay 1, 2025
  9. Junio C HamanoMay 1, 2025
  10. 4/4 git-worktree doc: update mark-up of synopsis option descriptionsJunio C Hamano, May 1, 2025
  11. 0/3 A handful of doc synopsis/options updateJunio C Hamano, May 3, 2025
  12. 1/3 git-verify-* doc: update mark-up of synopsis option descriptionsJunio C Hamano, May 3, 2025
  13. 2/3 git-{var,write-tree} docs: update mark-up of synopsis option descriptionsJunio C Hamano, May 3, 2025
  14. 3/3 git-daemon doc: update mark-up of synopsis option descriptionsJunio C Hamano, May 3, 2025
  15. Additional changesJean-Noël Avila, May 7, 2025
  16. Additional changesJean-Noël Avila, May 7, 2025
  17. Junio C HamanoMay 8, 2025
  18. Jean-Noël AVILAMay 9, 2025
  19. Junio C HamanoMay 9, 2025
  20. Jean-Noël AVILAMay 9, 2025
  21. Junio C HamanoMay 9, 2025
  22. 0/4 Additional changesJean-Noël Avila, May 10, 2025
  23. 1/4 git-daemon doc: update mark-up of synopsis option descriptionsJean-Noël Avila, May 10, 2025
  24. 2/4 git-{var,write-tree} docs: update mark-up of synopsis option descriptionsJean-Noël Avila, May 10, 2025
  25. 3/4 git-verify-* doc: update mark-up of synopsis option descriptionsJean-Noël Avila, May 10, 2025
  26. 4/4 git-var doc: fix usage of $ENV_VAR vs ENV_VARJean-Noël Avila, May 10, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.