Re: RFC: git diff colorization idea
- From
Wincent Colaiuta <win@wincent.com>
- Date
- Jan 23, 2009, 06:16 UTC
- Message-ID
- <5034E8A9-2B17-4368-8EDF-5FEE61BB2BAD@wincent.com>
- In-Reply-To
- <7vhc3q6evi.fsf@gitster.siamese.dyndns.org>
El 23/1/2009, a las 1:32, Junio C Hamano escribió:
Show 13 quoted lines
> Wincent Colaiuta <win@wincent.com> writes: > >> I'm also thinking that perhaps a per-character approach might be >> useful here instead of a per-word one (it would make that last hunk >> look better in the mock-up screenshot that I posted); if I go the >> per- >> character route then that suggests that "--color-chars" might be the >> right option name, and the color slots would then be >> color.diff.new.char and color.diff.old.char. >> >> Any feedback or suggestions before I get in too deep? > > I personally find your "prposal" picture too loud to my eye.
Yes, mine too. I wouldn't actually use those colors in practice. (Doubly so because the "removed" color looks like the "whitespace error" color.)
I'll whip something up with non-garish defaults.
Cheers, Wincent