git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 02/12] git p4 test: use p4d -L option to suppress log messages

From
Luke Diamand <luke@diamand.org>
Date
Aug 17, 2012, 06:07 UTC
Message-ID
<502DDFB7.2010408@diamand.org>
In-Reply-To
<1345160114-27654-3-git-send-email-pw@padd.com>
On 17/08/12 00:35, Pete Wyckoff wrote:
> Send p4d output to a logfile in the $TRASH_DIRECTORY.
> Its messages add no value to testing.

I'm not totally sold on this; I still fairly frequently see weird errors from p4d and these help me work out what's going on. For example, at the moment if you run a test too quickly after the last one, then it won't start up (or something like that).

The problem with hiding the error messages is that I don't think I will think to look in this log file if tests start failing.

Show 25 quoted lines
>
> Signed-off-by: Pete Wyckoff<pw@padd.com>
> ---
>   t/lib-git-p4.sh | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/t/lib-git-p4.sh b/t/lib-git-p4.sh
> index 482eeac..edb4033 100644
> --- a/t/lib-git-p4.sh
> +++ b/t/lib-git-p4.sh
> @@ -35,12 +35,13 @@ db="$TRASH_DIRECTORY/db"
>   cli=$(test-path-utils real_path "$TRASH_DIRECTORY/cli")
>   git="$TRASH_DIRECTORY/git"
>   pidfile="$TRASH_DIRECTORY/p4d.pid"
> +logfile="$TRASH_DIRECTORY/p4d.log"
>
>   start_p4d() {
>   	mkdir -p "$db" "$cli" "$git"&&
>   	rm -f "$pidfile"&&
>   	(
> -		p4d -q -r "$db" -p $P4DPORT&
> +		p4d -q -r "$db" -p $P4DPORT -L "$logfile"&
>   		echo $!>"$pidfile"
>   	)&&
>
Previous: Pete WyckoffNext: Pete Wyckoff
Message 5 of 21 in “git p4: submit conflict handling”
  1. 00/12 git p4: submit conflict handlingPete Wyckoff, Aug 16, 2012
  2. 01/12 git p4 test: remove bash-ism of combined export/assignmentPete Wyckoff, Aug 16, 2012
  3. Junio C HamanoAug 17, 2012
  4. 02/12 git p4 test: use p4d -L option to suppress log messagesPete Wyckoff, Aug 16, 2012
  5. Luke DiamandAug 17, 2012
  6. 03/12 git p4: gracefully fail if some commits could not be appliedPete Wyckoff, Aug 16, 2012
  7. Johannes SixtAug 17, 2012
  8. Pete WyckoffAug 17, 2012
  9. Luke DiamandAug 17, 2012
  10. Pete WyckoffAug 17, 2012
  11. 04/12 git p4: remove submit failure options [a]pply and [w]ritePete Wyckoff, Aug 16, 2012
  12. 05/12 git p4: move conflict prompt into run, use [c]ontinue and [q]uitPete Wyckoff, Aug 16, 2012
  13. 06/12 git p4: standardize submit cancel due to unchanged templatePete Wyckoff, Aug 16, 2012
  14. 07/12 git p4: test clean-up after failed submit, fix added filesPete Wyckoff, Aug 16, 2012
  15. 08/12 git p4: rearrange submit template constructionPete Wyckoff, Aug 16, 2012
  16. 09/12 git p4: revert deleted files after submit cancelPete Wyckoff, Aug 16, 2012
  17. 10/12 git p4: accept -v for --verbosePete Wyckoff, Aug 16, 2012
  18. 11/12 git p4: add submit --dry-run optionPete Wyckoff, Aug 16, 2012
  19. 12/12 git p4: add submit --prepare-p4-only optionPete Wyckoff, Aug 16, 2012
  20. Luke DiamandAug 17, 2012
  21. Pete WyckoffAug 17, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.