Re: File path not escaped in warning message

From

Janusz Białobrzewski <jbialobr@o2.pl>

Date

Aug 5, 2012, 12:05 UTC

Message-ID

<501E616E.6000907@o2.pl>

In-Reply-To

<7v39429u58.fsf@alter.siamese.dyndns.org>

Here is output from linux:

diff --git a/1<B1>.txt b/1<B1>.txt
index 281ad6f..9444a66 100644
--- a/1<B1>.txt
+++ b/1<B1>.txt
@@ -1,2 +1,2 @@
 aaaa
-bbb
+bbbc


[janusz@mikrus JavaCommon]$ git config --unset core.quotepath
[janusz@mikrus JavaCommon]$ git config --add core.quotepath true
[janusz@mikrus JavaCommon]$ git diff  --unified=3 -- "1ą.txt"
warning: LF will be replaced by CRLF in 1<B1>.txt.
The file will have its original line endings in your working directory.
diff --git "a/1\261.txt" "b/1\261.txt"
index 281ad6f..9444a66 100644
--- "a/1\261.txt"
+++ "b/1\261.txt"
@@ -1,2 +1,2 @@
 aaaa
-bbb
+bbbc

Janusz Białobrzewski.

Junio C Hamano pisze:
> Janusz Białobrzewski <jbialobr@o2.pl> writes:
>
>   
>> I have enabled core.quotepath, but file path in warning isn't escaped:
>> File name is 1ą.txt its content is encoded in windows-1250
>> Output of git diff after reencoding to windows1250 is:
>>
>> warning: LF will be replaced by CRLF in 1Ä….txt.
>> The file will have its original line endings in your working directory.
>>
>> But I expected it to be:
>>
>> warning: LF will be replaced by CRLF in 1\304\205.txt.
>> The file will have its original line endings in your working directory.
>>     
>
> Do msysgit folks want to look into this, perhaps?
>
> Thanks.
>
>