git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Make git-svn Use accessors for paths and urls

From
Michael G Schwern <schwern@pobox.com>
Date
Jul 28, 2012, 07:40 UTC
Message-ID
<50139755.7020105@pobox.com>
In-Reply-To
<20120728030959.GA3020@burratino>
On 2012.7.27 8:10 PM, Jonathan Nieder wrote:
Show 5 quoted lines
>> This is the last refactoring patch series.  After this bugs, start
>> getting fixed.
> 
> I just wanted to say thanks for your thoughtful presentation of this
> code.  I was worried before, but these have been pleasantly submitted.
You're welcome.  I've gained at least three levels in rebasing in the process.
> If you have a chance at some point to offer advice, I'd love to add
> the information to Documentation/SubmittingPatches that was missing.
> Proposed text is ideal, but outline form or a list of missing aspects
> and confusing existing coverage would be fine, too.
Remind me when I'm done with the 1.7 fix please?
-- 
You are wicked and wrong to have broken inside and peeked at the
implementation and then relied upon it.
	-- tchrist in <31832.969261130@chthon>
Previous: Jonathan NiederNext: Jonathan Nieder
Message 17 of 18 in “Make git-svn Use accessors for paths and urls”
  1. Michael G. SchwernJul 27, 2012
  2. 1/5 Make Git::SVN use accessors internally for path.Michael G. Schwern, Jul 27, 2012
  3. Jonathan NiederSep 17, 2012
  4. 1/5 Git::SVN: introduce path accessorJonathan Nieder, Sep 17, 2012
  5. 2/5 Git::SVN: use accessor to read pathJonathan Nieder, Sep 17, 2012
  6. 3/5 Git::SVN: use accessor to write pathJonathan Nieder, Sep 17, 2012
  7. 4/5 Git::SVN::_new: use accessor to write path fieldJonathan Nieder, Sep 17, 2012
  8. 5/5 Git::SVN: rename private path fieldJonathan Nieder, Sep 17, 2012
  9. Junio C HamanoSep 18, 2012
  10. Eric WongSep 18, 2012
  11. 2/5 Make Git::SVN use an accessor for URLs internally.Michael G. Schwern, Jul 27, 2012
  12. 3/5 Make Git::SVN::Ra use an accessor for URLsMichael G. Schwern, Jul 27, 2012
  13. 4/5 Change the rest of the code to use Git::SVN->path instead of the hash directly.Michael G. Schwern, Jul 27, 2012
  14. 5/5 Change the rest of the code to use the Git::SVN and Git::SVN::Ra url accessors.Michael G. Schwern, Jul 27, 2012
  15. Eric WongJul 28, 2012
  16. Jonathan NiederJul 28, 2012
  17. Michael G SchwernJul 28, 2012
  18. Jonathan NiederJul 28, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.