git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Importing Mozilla CVS into git

From
BJBertrand Jacquin <beber.mailing@gmail.com>
Date
Jun 4, 2006, 02:24 UTC
Message-ID
<4fb292fa0606031924v42024765l9f068f6915bfcf96@mail.gmail.com>
In-Reply-To
<Pine.LNX.4.64.0606031631480.5498@g5.osdl.org>
On 6/4/06, Linus Torvalds <torvalds@osdl.org> wrote:
Show 31 quoted lines
>
>
> On Sun, 4 Jun 2006, Robin Rosenberg (list subscriber) wrote:
> >
> > (Yet) Another problem is that many windows tools use CR LF as the line ending.
> > Almost all windows editors default to CRLF and some detect existing line
> > endings. No editing with notepad anymore. Of course that is a problem
> > regardless of whether a git or cvs client is used. You'll get these big
> > everything-changed commits that alter between CRLF and LF.
>
> The only sane approach there (if you want to be at all cross-platform) is
> to just force everybody to _commit_ in UNIX '\n'-only format. Especially
> as most Windows tools probably handle that fine on reading (just have
> trouble writing them).
>
> And that shouldn't actually be that hard to do. The most trivial approach
> is to have just a pre-trigger on commits, but let's face it, that would
> not be a good "full" solution. A better one is to just make the whole
> "git update-index" thing just have a "automatically ignore CR/LF" mode.
>
> Which really shouldn't be that hard. I think it's literally a matter of
> teaching "index_fd()" in sha1_file.c to recognize text-files, and remove
> CR/LF from them. All done (except to add the flag that enables the
> detection, of course - just so that sane systems won't have the overhead
> or the "corrupt binary files" issue).
>
> Something like this is TOTALLY UNTESTED!
>
> (You also need to teach "diff" to ignore differences in cr/lf, and this
> patch is bad because it's unconditional, and probably doesn't work
> anyway, but hey, the idea is possibly sound. Maybe)

Is it also apply for binary files ? It could corrupt files as well. If end-user application don't understand '\n' but '\r\n', you can have bad issues (I think to notepad here (yes crappy, but ..)). Couldn't it be configurable ?

-- 
# Beber : beber@gna.org
# IM : beber@jabber.fr
# http://guybrush.ath.cx, irc://irc.freenode.net/#{e.fr,gentoofr}
Previous: Linus TorvaldsNext: Jakub Narebski
Message 25 of 47 in “Importing Mozilla CVS into git”
  1. Jon SmirlJun 1, 2006
  2. Keith PackardJun 1, 2006
  3. Jon SmirlJun 2, 2006
  4. Keith PackardJun 2, 2006
  5. Jon SmirlJun 2, 2006
  6. Shawn PearceJun 2, 2006
  7. Keith PackardJun 2, 2006
  8. Jon SmirlJun 2, 2006
  9. Keith PackardJun 2, 2006
  10. Jon SmirlJun 2, 2006
  11. Shawn PearceJun 2, 2006
  12. Pavel RoskinJun 2, 2006
  13. Shawn PearceJun 2, 2006
  14. Johannes SchindelinJun 2, 2006
  15. Jon SmirlJun 2, 2006
  16. Igor BukanovJun 7, 2006
  17. Pavel RoskinJun 7, 2006
  18. Jon SmirlJun 7, 2006
  19. Jakub NarebskiJun 7, 2006
  20. Linus TorvaldsJun 7, 2006
  21. Martin LanghoffJun 7, 2006
  22. Martin LanghoffJun 2, 2006
  23. Robin Rosenberg (list subscriber)Jun 3, 2006
  24. Linus TorvaldsJun 3, 2006
  25. Bertrand JacquinJun 4, 2006
  26. Jakub NarebskiJun 4, 2006
  27. Linus TorvaldsJun 4, 2006
  28. Robin Rosenberg (list subscriber)Jun 4, 2006
  29. Linus TorvaldsJun 4, 2006
  30. Robin Rosenberg (list subscriber)Jun 4, 2006
  31. Robin Rosenberg (list subscriber)Jun 4, 2006
  32. Linus TorvaldsJun 4, 2006
  33. Yakov LernerJun 5, 2006
  34. Jon SmirlJun 3, 2006
  35. Jon SmirlJun 3, 2006
  36. Martin LanghoffJun 6, 2006
  37. Jon SmirlJun 6, 2006
  38. Martin LanghoffJun 6, 2006
  39. Keith PackardJun 7, 2006
  40. Jon SmirlJun 7, 2006
  41. Linus TorvaldsJun 1, 2006
  42. Jon SmirlJun 2, 2006
  43. Linus TorvaldsJun 2, 2006
  44. Junio C HamanoJun 2, 2006
  45. Linus TorvaldsJun 2, 2006
  46. Junio C HamanoJun 2, 2006
  47. Martin LanghoffJun 2, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.