git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH resend] SubmittingPatches: mention the git contacts command

From
Derrick Stolee <stolee@gmail.com>
Date
Apr 11, 2018, 20:38 UTC
Message-ID
<4f19d1b0-72e1-4c9f-6027-16e0e6cfc24d@gmail.com>
In-Reply-To
<20180411202000.31086-1-t.gummerer@gmail.com>
On 4/11/2018 4:20 PM, Thomas Gummerer wrote:
Show 17 quoted lines
> Instead of just mentioning 'git blame' and 'git shortlog', which make it
> quite hard for new contributors to pick out the appropriate list of
> people to cc on their patch series, mention the 'git contacts' utility,
> which makes it much easier to get a reasonable list of contacts for a
> change.
>
> This should help new contributors pick out a reasonable cc list by
> simply using a single command.
>
> Signed-off-by: Thomas Gummerer <t.gummerer@gmail.com>
> ---
>
> I've originally sent this at <20180316213323.GC2224@hank>, during an
> the rc period.  Eric had some comments, which I interpreted as being
> okay with the change (hope I'm not mistaken there :)).  As I still
> think this would be an improvement for new contributors, I'm resending
> it here.

I didn't know about this tool, and it seems helpful. I plan to use it now. Thanks!

Show 18 quoted lines
>   Documentation/SubmittingPatches | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
> index a1d0feca36..945f8edb46 100644
> --- a/Documentation/SubmittingPatches
> +++ b/Documentation/SubmittingPatches
> @@ -260,8 +260,8 @@ that starts with `-----BEGIN PGP SIGNED MESSAGE-----`.  That is
>   not a text/plain, it's something else.
>   
>   Send your patch with "To:" set to the mailing list, with "cc:" listing
> -people who are involved in the area you are touching (the output from
> -`git blame $path` and `git shortlog --no-merges $path` would help to
> +people who are involved in the area you are touching (the `git
> +contacts` command in `contrib/contacts/` can help to
>   identify them), to solicit comments and reviews.
>   
>   :1: footnote:[The current maintainer: gitster@pobox.com]
Previous: Thomas GummererNext: Eric Sunshine
Message 2 of 3 in “SubmittingPatches: mention the git contacts command”
  1. SubmittingPatches: mention the git contacts commandThomas Gummerer, Apr 11, 2018
  2. Derrick StoleeApr 11, 2018
  3. Eric SunshineApr 11, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.