Re: [PATCH v2] bisect: Honor log.date

From: Peter Krefting <peter@softwolves.pp.se>
Date: Apr 16, 2024, 19:53 UTC
Message-ID: <4f0456c0-e926-ee60-4e14-6b8ed80d2ace@softwolves.pp.se>
In-Reply-To: <xmqq8r1dfh65.fsf@gitster.g>

Junio C Hamano:

Show 10 quoted lines

> then the codepath we are changing from using diff-tree to show can 
> do something like:
>
> 	struct git_global_state state = GIT_GLOBAL_STATE_INIT;
> 	struct strvec args = STRVEC_INIT;
>
>        strvec_pushl(&args, ...);
>        cmd__show(&state, args.nr , args.v);
>
> and expect that cmd__show() will do the _right thing_, right?

In this particular case, calling "git show" is really the last thing we want to do; so if we can move the cleanup that happens after it (that ends the bisect), it should be able to just take over the current process with a call to show, without needing to re-exec.

And calling back to the libification question, I would see this part of the bisect command to be something that would run *on top of* the library (with possibly an API to poke bad/good states into it), so I don't think that objection holds for this particular case.

-- 
\\// Peter - http://www.softwolves.pp.se/