Re: [PATCH 0/2] gitk: Support of SHA256 repos

From: Johannes Sixt <j6t@kdbg.org>
Date: May 8, 2025, 06:21 UTC
Message-ID: <4ef123de-a338-4c06-8983-aa6c5380ad13@kdbg.org>
In-Reply-To: <20250320154136.23262-1-tiwai@suse.de>

Am 20.03.25 um 16:41 schrieb Takashi Iwai:

Show 33 quoted lines

> Hi,
> 
> I recently stumbled on the problem of gitk with sha256 repo (while
> testing the new openSUSE package git workflow that enforces SHA256);
> gitk aborts immediately with a message "Can't parse git log output:
> {commit xxx..}".
> 
> After skimming over the net, I found the patch [*] posted in 4 years
> ago to add the support for sha256, but nothing happened since then,
> unfortunately.
> 
> So here is the revived patch for gitk to add sha256 support, with
> cleanups and corrections, in addition to the enhancement patch for the
> missing auto-select length config for sha256.
> 
> Only lightly tested on a few sha256 repos.
> 
> 
> Takashi
> 
> [*] https://patchwork.kernel.org/project/git/patch/pull.979.git.1623687519832.gitgitgadget@gmail.com
> 
> ===
> 
> Rostislav Krasny (1):
>   gitk: Add a basic support of SHA256 repositories into Gitk
> 
> Takashi Iwai (1):
>   gitk: Add auto-select length preference for SHA256
> 
>  gitk-git/gitk | 96 +++++++++++++++++++++++++++++++++++++--------------
>  1 file changed, 71 insertions(+), 25 deletions(-)
>

Thank you.

After these patches, I still see a few mentions of "40" that refer to object id lengths and are not converted.

- a comment above proc longid
- a regexp in proc shortids
- in proc setlink
- in proc mkpatch
- in proc mktag

They should be converted, too, I think.

-- Hannes