git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 1/2] sequencer: fix gpg option passed to merge subcommand

From
PWPhillip Wood <phillip.wood123@gmail.com>
Date
Oct 16, 2020, 17:25 UTC
Message-ID
<4bbf0055-ed50-6560-7208-dce9378389c8@gmail.com>
In-Reply-To
<xmqqy2k6cejl.fsf@gitster.c.googlers.com>
On 16/10/2020 17:37, Junio C Hamano wrote:
Show 8 quoted lines
> Phillip Wood <phillip.wood123@gmail.com> writes:
> 
>> ... Reviewers that only read the patch without loading up the
>> test file in their editor have no indication that the test should be
>> clearing the config variable.
> 
> It is not a review if the code being updated is not checked for
> sanity in its own context, is it?

It is disappointing that you have chosen to cut the original to those few lines and reply just to them. The original message made the broader point that having to check the previous tests in a file to figure out what the state is at the beginning of any new test that gets added makes life harder than it needs to be both for contributors and reviewers.

Phillip
Previous: Junio C HamanoNext: Junio C Hamano
Message 17 of 18 in “sequencer: fix gpg option passed to merge subcommand”
  1. 1/2 sequencer: fix gpg option passed to merge subcommandSamuel Čavoj, Oct 12, 2020
  2. 2/2 sequencer: pass explicit --no-gpg-sign to mergeSamuel Čavoj, Oct 12, 2020
  3. Junio C HamanoOct 13, 2020
  4. Phillip WoodOct 13, 2020
  5. Samuel ČavojOct 12, 2020
  6. Phillip WoodOct 13, 2020
  7. Samuel ČavojOct 13, 2020
  8. Phillip WoodOct 13, 2020
  9. Phillip WoodOct 13, 2020
  10. Samuel ČavojOct 13, 2020
  11. Phillip WoodOct 13, 2020
  12. Junio C HamanoOct 13, 2020
  13. Samuel ČavojOct 13, 2020
  14. Junio C HamanoOct 14, 2020
  15. Phillip WoodOct 16, 2020
  16. Junio C HamanoOct 16, 2020
  17. Phillip WoodOct 16, 2020
  18. Junio C HamanoOct 16, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.