[PATCH 2/2] repo: remove redundant variable shadow in stats_table_print_structure
- From
Mansi Singh via GitGitGadget <gitgitgadget@gmail.com>
- Date
- Mar 10, 2026, 02:16 UTC
- Message-ID
- <4adf6d4dca90e2c7f780d594a533c21247c459b8.1773109018.git.gitgitgadget@gmail.com>
- In-Reply-To
- <pull.2062.git.1773109018.gitgitgadget@gmail.com>
From: Mansi Singh <mansimaanu8627@gmail.com>
In stats_table_print_structure(), the variable 'entry' is declared at the top of the loop body and assigned from item->util. Inside the 'if (entry)' block, the same variable is redeclared and assigned identically, shadowing the outer declaration unnecessarily.
Remove the inner redeclaration since the outer 'entry' is already available and non-NULL at that point.
Signed-off-by: Mansi Singh <mansimaanu8627@gmail.com> --- builtin/repo.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/builtin/repo.c b/builtin/repo.c index 0ea045abc1..5540bd25d2 100644 --- a/builtin/repo.c +++ b/builtin/repo.c @@ -412,7 +412,6 @@ static void stats_table_print_structure(const struct stats_table *table) const char *unit = ""; if (entry) { - struct stats_table_entry *entry = item->util; value = entry->value; if (entry->unit) unit = entry->unit;
-- gitgitgadget