git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/2] repo: remove redundant variable shadow in stats_table_print_structure

From
Mansi Singh via GitGitGadget <gitgitgadget@gmail.com>
Date
Mar 10, 2026, 02:16 UTC
Message-ID
<4adf6d4dca90e2c7f780d594a533c21247c459b8.1773109018.git.gitgitgadget@gmail.com>
In-Reply-To
<pull.2062.git.1773109018.gitgitgadget@gmail.com>
From: Mansi Singh <mansimaanu8627@gmail.com>

In stats_table_print_structure(), the variable 'entry' is declared at the top of the loop body and assigned from item->util. Inside the 'if (entry)' block, the same variable is redeclared and assigned identically, shadowing the outer declaration unnecessarily.

Remove the inner redeclaration since the outer 'entry' is already available and non-NULL at that point.

Signed-off-by: Mansi Singh <mansimaanu8627@gmail.com>
---
 builtin/repo.c | 1 -
 1 file changed, 1 deletion(-)
diff --git a/builtin/repo.c b/builtin/repo.c
index 0ea045abc1..5540bd25d2 100644
--- a/builtin/repo.c
+++ b/builtin/repo.c
@@ -412,7 +412,6 @@ static void stats_table_print_structure(const struct stats_table *table)
 		const char *unit = "";
 
 		if (entry) {
-			struct stats_table_entry *entry = item->util;
 			value = entry->value;
 			if (entry->unit)
 				unit = entry->unit;
-- 
gitgitgadget
Previous: Mansi via GitGitGadgetNext: K Jayatheerth
Message 3 of 5 in “repo: remove redundant variable shadow in stats_table_print_structure”
  1. 0/2 repo: remove redundant variable shadow in stats_table_print_structureMansi Singh via GitGitGadget, Mar 10, 2026
  2. 1/2 t7605: use test_path_is_file instead of test -fMansi via GitGitGadget, Mar 10, 2026
  3. 2/2 repo: remove redundant variable shadow in stats_table_print_structureMansi Singh via GitGitGadget, Mar 10, 2026
  4. K JayatheerthMar 10, 2026
  5. Junio C HamanoMar 10, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.