Re: [PATCH] Retain multiple -q/-v occurrences in git pull

From: Tuncer Ayaz <tuncer.ayaz@gmail.com>
Date: Nov 19, 2008, 22:47 UTC
Message-ID: <4ac8254d0811191447q7c9c475fka30a15c21b10524e@mail.gmail.com>
In-Reply-To: <85647ef50811190346x11aea0fay3a8a7dfd8ddf6abc@mail.gmail.com>

On Wed, Nov 19, 2008 at 12:46 PM, Constantine Plotnikov <constantine.plotnikov@gmail.com> wrote:

Show 9 quoted lines

> On Tue, Nov 18, 2008 at 1:09 AM, Tuncer Ayaz <tuncer.ayaz@gmail.com> wrote:
>> To support counting -q/-v options in git pull retain
>> them by concatenating.
>>
> [rest of message cut]
>
> By the way, there is yet another way to invoke git fetch. It is "git
> remote update". Possibly it should support "-v" and "-q" options for
> consistency as well.

Yes, we could add -q to builtin-remote and also make sure that it passes the already existing -v and maybe a yet-to-be-added -q to the fetch command. I want to be first sure what the overall strategy regarding -q/-v is.

Right now we have some code which uses OPT__VERBOSE/OPT__QUIET and some new code which uses the newly-added OPT__VERBOSITY.

These are the options I can see:
1) Use the old and new macros and decide in each module which one to use
2) Get rid off OPT__VERBOSE and OPT__QUIET and use OPT__VERBOSITY only
3) Think about new ways to handle all of this. Possibly some new print_* macros?

Any opinions?