Re: [PATCH] Teach/Fix pull/fetch -q/-v options

From: Tuncer Ayaz <tuncer.ayaz@gmail.com>
Date: Nov 17, 2008, 22:24 UTC
Message-ID: <4ac8254d0811171424t43676207v5d842ba8ab6e2944@mail.gmail.com>
In-Reply-To: <85647ef50811170303i17049994n356c384693502685@mail.gmail.com>

On Mon, Nov 17, 2008 at 12:03 PM, Constantine Plotnikov <constantine.plotnikov@gmail.com> wrote:

Show 9 quoted lines

> On Mon, Nov 17, 2008 at 1:51 PM, Junio C Hamano <gitster@pobox.com> wrote:
>> "Tuncer Ayaz" <tuncer.ayaz@gmail.com> writes:
>>
>>> I think you need to have something like the following applied on top of
>>> what's in pu to be able to use "pull -v -v -v" and be able to count the
>>> occurrences via parse-options.c. What do you think?
>>
> I'm just interested why not just optional level argument to verbosity
> like --verbose=2 or -v2?

I'm not really sure which one is better but do prefer the "-v -v -v" way as it seems to be common practice in tools that support it. Also I don't want to make git cli different than most other cli tools. This does not mean that common practice is the best choice.

I think allowing an integer param makes our cli worse and allows usage like --verbose=25. verbose=25 is not sane in my personal view.

$ git pull --verbose # same as --verbose=1? $ git pull --verbose=42 # will do the right thing always by AI? $ git pull --verbose=0 # will do what? maybe quiet=1?

I say let's keep it simple so that no one starts getting the idea that it's fine to have more than a handful occurrences of -v or -q.