git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 5/7] oidset: introduce 'oidset_size'

From
Taylor Blau <me@ttaylorr.com>
Date
Apr 14, 2020, 04:04 UTC
Message-ID
<4a9798ba6f3aab081dff5e40e1d91568cf4ba23b.1586836700.git.me@ttaylorr.com>
In-Reply-To
<cover.1586836700.git.me@ttaylorr.com>

Occasionally, it may be useful for callers to know the number of object IDs in an oidset. Right now, the only way to compute this is to call 'kh_size' on the internal 'kh_set_oid_t'.

Similar to how we wrap other 'kh_*' functions over the 'oidset' type, let's allow callers to compute this value by introducing 'oidset_size'.

We will add its first caller in the subsequent commit.
Signed-off-by: Taylor Blau <me@ttaylorr.com>
---
 oidset.c | 5 +++++
 oidset.h | 5 +++++
 2 files changed, 10 insertions(+)
diff --git a/oidset.c b/oidset.c
index f63ce818f6..15d4e18c37 100644
--- a/oidset.c
+++ b/oidset.c
@@ -36,6 +36,11 @@ void oidset_clear(struct oidset *set)
 	oidset_init(set, 0);
 }
 
+int oidset_size(struct oidset *set)
+{
+	return kh_size(&set->set);
+}
+
 void oidset_parse_file(struct oidset *set, const char *path)
 {
 	FILE *fp;
diff --git a/oidset.h b/oidset.h
index d8a106b127..8261c36b91 100644
--- a/oidset.h
+++ b/oidset.h
@@ -54,6 +54,11 @@ int oidset_insert(struct oidset *set, const struct object_id *oid);
  */
 int oidset_remove(struct oidset *set, const struct object_id *oid);
 
+/**
+ * Returns the number of oids in the set.
+ */
+int oidset_size(struct oidset *set);
+
 /**
  * Remove all entries from the oidset, freeing any resources associated with
  * it.
-- 
2.26.0.106.g9fadedd637
Previous: Taylor BlauNext: Taylor Blau
Message 6 of 19 in “commit-graph: split strategies, '--[no-]check-oids'”
  1. 0/7 commit-graph: split strategies, '--[no-]check-oids'Taylor Blau, Apr 14, 2020
  2. 1/7 t/helper/test-read-graph.c: support commit-graph chainsTaylor Blau, Apr 14, 2020
  3. 2/7 builtin/commit-graph.c: support for '--split[=<strategy>]'Taylor Blau, Apr 14, 2020
  4. 3/7 builtin/commit-graph.c: introduce split strategy 'no-merge'Taylor Blau, Apr 14, 2020
  5. 4/7 builtin/commit-graph.c: introduce split strategy 'replace'Taylor Blau, Apr 14, 2020
  6. 5/7 oidset: introduce 'oidset_size'Taylor Blau, Apr 14, 2020
  7. 6/7 commit-graph.h: replace 'commit_hex' with 'commits'Taylor Blau, Apr 14, 2020
  8. 7/7 commit-graph.c: introduce '--[no-]check-oids'Taylor Blau, Apr 14, 2020
  9. Taylor BlauApr 15, 2020
  10. Taylor BlauApr 15, 2020
  11. SZEDER GáborApr 22, 2020
  12. Taylor BlauApr 22, 2020
  13. SZEDER GáborApr 24, 2020
  14. Taylor BlauMay 1, 2020
  15. Jeff KingMay 3, 2020
  16. Junio C HamanoMay 3, 2020
  17. Jeff KingMay 4, 2020
  18. Junio C HamanoMay 4, 2020
  19. Taylor BlauMay 4, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.