git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] submodules: don't stumble over symbolic links when cloning recursively

From
Johannes Sixt <j6t@kdbg.org>
Date
Jul 12, 2012, 17:12 UTC
Message-ID
<4FFF0575.3050203@kdbg.org>
In-Reply-To
<4FFDEB46.6010403@web.de>
Am 11.07.2012 23:08, schrieb Jens Lehmann:
Show 9 quoted lines
> Am 11.07.2012 22:39, schrieb Johannes Sixt:
>> At this point we can be in a subdirectory of the worktree. With
>> cd_to_toplevel we move up in the directory hierarchy ("cd out"). Then a
>> relative $gitdir or $sm_path now points to the wrong directory. No?
> 
> Nope, "git submodule" will refuse to run in anything but the root of
> the worktree. So we already are at the toplevel and use "cd_to_toplevel"
> only to resolve any symlinks present in $PWD. Looks like a comment
> explaining that above those lines would be a good idea ... will add one.

Ah, OK. I missed the lack of SUBDIRECTORY_OK=Yes, but noticed a few cd_to_toplevel sprinkled throughout the script, so I thought it was OK to be in a subdirectory.

-- Hannes
Previous: Jens Lehmann
Message 6 of 6 in “submodules: don't stumble over symbolic links when cloning recursively”
  1. submodules: don't stumble over symbolic links when cloning recursivelyJens Lehmann, Jul 11, 2012
  2. Johannes SixtJul 11, 2012
  3. Jens LehmannJul 11, 2012
  4. Johannes SixtJul 11, 2012
  5. Jens LehmannJul 11, 2012
  6. Johannes SixtJul 12, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.