git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: t4014 broken by 43ae9f47ab: format-patch: use default email for generating message ids

From
Michael Haggerty <mhagger@alum.mit.edu>
Date
May 24, 2012, 20:49 UTC
Message-ID
<4FBE9EF3.9020902@alum.mit.edu>
In-Reply-To
<20120524171640.GB3161@sigill.intra.peff.net>
On 05/24/2012 07:16 PM, Jeff King wrote:
Show 19 quoted lines
> On Thu, May 24, 2012 at 02:01:57PM +0200, Michael Haggerty wrote:
>
>> On my setup, the above commit causes 12 tests in t4014 to fail.  For
>> example, test 25:
>>
>>> -Message-Id:<0>
>>> +Message-Id:<1135adfeed86678c55e1aad7c568046ee8215660.1337860646.git.mhagger@michael.(none)>
>
> Thanks for the report. I know exactly what the issue is, as it came up
> in the discussion of the original series. 43ae9f47ab stopped using
> git_committer_info (which looks at $GIT_COMMITTER_EMAIL) for the end of
> the message-id and started using the default-generated email directly.
>
> Nobody should care, because either:
>
>    1. The defaults set up a reasonable hostname for your machine.
>
>    2. They do not, but you adjust it by setting user.email. Otherwise,
>       your author ident would have this bogus email in it.

I'm trying hard not to get sucked into this topic (I just want the test suite to work again!) but I infer that the reason for the failure in my setup is that I have a global user.name but no global user.email configured. I want git to remind me to configure user.email at the repository level so that I can set my work email address for proprietary projects and my personal email for open-source projects.

Ignorant idea: since this test is executed in a test repo, would it help to set a dummy user.name and user.email at the test repository level using "git config", perhaps as part of the standard test repo setup?

Michael
-- 
Michael Haggerty
mhagger@alum.mit.edu
http://softwareswirl.blogspot.com/
Previous: Jeff KingNext: Jeff King
Message 15 of 16 in “t4014 broken by 43ae9f47ab: format-patch: use default email for generating message ids”
  1. Michael HaggertyMay 24, 2012
  2. Jeff KingMay 24, 2012
  3. Junio C HamanoMay 24, 2012
  4. Jeff KingMay 24, 2012
  5. Jeff KingMay 24, 2012
  6. 1/7 ident: refactor empty ident error messageJeff King, May 24, 2012
  7. 2/7 ident: refactor NO_DATE flag in fmt_identJeff King, May 24, 2012
  8. 3/7 ident: let callers omit name with fmt_indentJeff King, May 24, 2012
  9. 4/7 format-patch: use GIT_COMMITTER_EMAIL in message idsJeff King, May 24, 2012
  10. 5/7 ident: rename IDENT_ERROR_ON_NO_NAME to IDENT_STRICTJeff King, May 24, 2012
  11. 6/7 ident: reject bogus email addresses with IDENT_STRICTJeff King, May 24, 2012
  12. 7/7 format-patch: do not use bogus email addresses in message idsJeff King, May 24, 2012
  13. Junio C HamanoMay 25, 2012
  14. Jeff KingMay 25, 2012
  15. Michael HaggertyMay 24, 2012
  16. Jeff KingMay 24, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.