git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/5] blame: use hunk_func(), part 1

From
René Scharfe <rene.scharfe@lsrfire.ath.cx>
Date
May 9, 2012, 20:21 UTC
Message-ID
<4FAAD1E4.30906@lsrfire.ath.cx>
In-Reply-To
<4FAAD13E.8030806@lsrfire.ath.cx>

Use blame_chunk_cb() directly as hunk_func() callback, without detour through xdi_diff_hunks().

Signed-off-by: Rene Scharfe <rene.scharfe@lsrfire.ath.cx>
---
 builtin/blame.c |   17 ++++++++++++-----
 1 file changed, 12 insertions(+), 5 deletions(-)
diff --git a/builtin/blame.c b/builtin/blame.c
index 324d476..9ae5cf3 100644
--- a/builtin/blame.c
+++ b/builtin/blame.c
@@ -759,12 +759,14 @@ struct blame_chunk_cb_data {
 	long tlno;
 };
 
-static void blame_chunk_cb(void *data, long same, long p_next, long t_next)
+static int blame_chunk_cb(long start_a, long count_a,
+			  long start_b, long count_b, void *data)
 {
 	struct blame_chunk_cb_data *d = data;
-	blame_chunk(d->sb, d->tlno, d->plno, same, d->target, d->parent);
-	d->plno = p_next;
-	d->tlno = t_next;
+	blame_chunk(d->sb, d->tlno, d->plno, start_b, d->target, d->parent);
+	d->plno = start_a + count_a;
+	d->tlno = start_b + count_b;
+	return 0;
 }
 
 /*
@@ -781,6 +783,8 @@ static int pass_blame_to_parent(struct scoreboard *sb,
 	struct blame_chunk_cb_data d;
 	xpparam_t xpp;
 	xdemitconf_t xecfg;
+	xdemitcb_t ecb;
+
 	memset(&d, 0, sizeof(d));
 	d.sb = sb; d.target = target; d.parent = parent;
 	last_in_target = find_last_in_target(sb, target);
@@ -795,7 +799,10 @@ static int pass_blame_to_parent(struct scoreboard *sb,
 	xpp.flags = xdl_opts;
 	memset(&xecfg, 0, sizeof(xecfg));
 	xecfg.ctxlen = 0;
-	xdi_diff_hunks(&file_p, &file_o, blame_chunk_cb, &d, &xpp, &xecfg);
+	xecfg.hunk_func = blame_chunk_cb;
+	memset(&ecb, 0, sizeof(ecb));
+	ecb.priv = &d;
+	xdi_diff(&file_p, &file_o, &xpp, &xecfg, &ecb);
 	/* The rest (i.e. anything after tlno) are the same as the parent */
 	blame_chunk(sb, d.tlno, d.plno, last_in_target, target, parent);
 
-- 
1.7.10.1
Previous: René ScharfeNext: René Scharfe
Message 3 of 7 in “xdiff: replace emit_func() with type-safe”
  1. 0/5 xdiff: replace emit_func() with type-safeRené Scharfe, May 9, 2012
  2. 1/5 xdiff: add hunk_func()René Scharfe, May 9, 2012
  3. 2/5 blame: use hunk_func(), part 1René Scharfe, May 9, 2012
  4. 3/5 blame: use hunk_func(), part 2René Scharfe, May 9, 2012
  5. 4/5 blame: factor out helper for calling xdi_diff()René Scharfe, May 9, 2012
  6. 5/5 xdiff: remove emit_func() and xdi_diff_hunks()René Scharfe, May 9, 2012
  7. Thomas RastMay 18, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.