Re: Git commit path vs rebase path

From: Johannes Sixt <j.sixt@viscovery.net>
Date: May 8, 2012, 06:22 UTC
Message-ID: <4FA8BBB0.1080406@viscovery.net>
In-Reply-To: <7vaa1j7vg1.fsf@alter.siamese.dyndns.org>

Am 5/7/2012 19:27, schrieb Junio C Hamano:

Show 23 quoted lines

> Steven Penny <svnpenn@gmail.com> writes:
> 
>> I have noticed
>>
>> git commit uses this path
>>
>> .git/COMMIT_EDITMSG
>>
>> git rebase uses this path
>>
>> /home/Steven/jquery/.git/rebase-merge/git-rebase-todo
>>
>> So git commit is using a relative path while git rebase is using absolute path.
>>
>> This causes problem in Windows if your editor does not understand linux paths,
>> e.g. notepad, Notepad2, Notepad++, etc.
> 
> ... the issue is _not_ that the path is
> absolute, it is that the path is given as a wrong kind of absolute path.
> 
> Which suggests that "$(cd "$GIT_DIR" && pwd)" must give a full path that
> is suitable for the platform, and your platform wants it to be something
> like "c:\home\steven\jquery\..."?

The problem should be mitigated by be39048a7 (git-sh-setup.sh: Add an pwd() function for MinGW), where the above now returns a Windows-style absolute path, albeit with forward slashes instead of the backslashes.

I don't know what "/home/..." is in Steven's case, because it should look more like "/c/home/..." unless it is an MSYS mount point, but even then it should be reported as Windows-style path with the new pwd function.

IOW, the problem should be fixed in the next release.

-- Hannes