git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 3/4] fetch-pack: test cases for the new --stdin option

From
Ivan Todoroski <grnch@gmx.net>
Date
Apr 3, 2012, 00:23 UTC
Message-ID
<4F7A4304.9040800@gmx.net>
In-Reply-To
<7v4nt2exlr.fsf@alter.siamese.dyndns.org>
On 02.04.2012 21:34, Junio C Hamano wrote:
Show 38 quoted lines
> Ivan Todoroski <grnch@gmx.net> writes:
> 
>> +test_expect_success 'setup tests for the --stdin parameter' '
>> +	for head in C D E F
>> +	do
>> +		add $head
>> +	done &&
>> +	for head in A B C D E F
>> +	do
>> +		git tag $head $head
>> +	done
>> +	cat >input <<EOF
>> +refs/heads/C
>> +refs/heads/A
>> +refs/heads/D
>> +refs/tags/C
>> +refs/heads/B
>> +refs/tags/A
>> +refs/heads/E
>> +refs/tags/B
>> +refs/tags/E
>> +refs/tags/D
>> +EOF
>> +	sort <input >expect
>> +	(
>> +	echo refs/heads/E &&
>> +	echo refs/tags/E &&
>> +	cat input
>> +	) >input.dup
>> +'
> 
> 
> This breaks && chain; also it is easier to read if indentation is used
> properly.
> 
> I'll queue it after fixing the above locally (the rest looked OK to me).
> 
> Thanks.

I just saw the neat <<- trick in your reworked version, nice! Somehow I've never stumbled on to that part of the bash man page before. :|

When I look back how many shell scripts I've mangled with indentation like above, it breaks my heart. :)

Previous: Junio C HamanoNext: Ivan Todoroski
Message 8 of 9 in “Clone fails on a repo with too many heads/tags”
  1. 0/4 Clone fails on a repo with too many heads/tagsIvan Todoroski, Apr 2, 2012
  2. 1/4 fetch-pack: new --stdin option to read refs from stdinIvan Todoroski, Apr 2, 2012
  3. Jeff KingApr 2, 2012
  4. 2/4 remote-curl: send the refs to fetch-pack on stdinIvan Todoroski, Apr 2, 2012
  5. Junio C HamanoApr 2, 2012
  6. 3/4 fetch-pack: test cases for the new --stdin optionIvan Todoroski, Apr 2, 2012
  7. Junio C HamanoApr 2, 2012
  8. Ivan TodoroskiApr 3, 2012
  9. 4/4 remote-curl: main test case for the OS command line overflowIvan Todoroski, Apr 2, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.