Re: [PATCH v3 3/4] fetch-pack: test cases for the new --stdin option
- From
Ivan Todoroski <grnch@gmx.net>
- Date
- Apr 3, 2012, 00:23 UTC
- Message-ID
- <4F7A4304.9040800@gmx.net>
- In-Reply-To
- <7v4nt2exlr.fsf@alter.siamese.dyndns.org>
On 02.04.2012 21:34, Junio C Hamano wrote:
Show 38 quoted lines
> Ivan Todoroski <grnch@gmx.net> writes: > >> +test_expect_success 'setup tests for the --stdin parameter' ' >> + for head in C D E F >> + do >> + add $head >> + done && >> + for head in A B C D E F >> + do >> + git tag $head $head >> + done >> + cat >input <<EOF >> +refs/heads/C >> +refs/heads/A >> +refs/heads/D >> +refs/tags/C >> +refs/heads/B >> +refs/tags/A >> +refs/heads/E >> +refs/tags/B >> +refs/tags/E >> +refs/tags/D >> +EOF >> + sort <input >expect >> + ( >> + echo refs/heads/E && >> + echo refs/tags/E && >> + cat input >> + ) >input.dup >> +' > > > This breaks && chain; also it is easier to read if indentation is used > properly. > > I'll queue it after fixing the above locally (the rest looked OK to me). > > Thanks.
I just saw the neat <<- trick in your reworked version, nice! Somehow I've never stumbled on to that part of the bash man page before. :|
When I look back how many shell scripts I've mangled with indentation like above, it breaks my heart. :)