git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: git rebase --root bug

From
CFChristopher Fretz <cfretz@icloud.com>
Date
May 11, 2023, 19:52 UTC
Message-ID
<4F6C462C-58EA-4E49-ACCC-303EFDD3E780@icloud.com>
In-Reply-To
<ZF0U6tneDjLfGxf1@nand.local>
> Wouldn't it suffice to consider the squash_onto commit as reachable the
> same way we do for `--indexed-objects`?
I think this is essentially what I was imagining, although I don’t know if it’d be considered the cleanest possible approach. I guess I just figured that the logic is already structured such that an empty commit is created to avoid having to add special handling for --root all throughout the rebase operation, and so it’s not such a stretch to then automatically consider that commit as always being reachable.
Rebase could also be reworked to not depend on the squash_onto in the case of a --root rebase, but I imagine this would be a much larger change.
Previous: Taylor BlauNext: Phillip Wood
Message 6 of 7 in “git rebase --root bug”
  1. Christopher FretzMay 10, 2023
  2. Kristoffer HaugsbakkMay 10, 2023
  3. Christopher FretzMay 11, 2023
  4. Phillip WoodMay 11, 2023
  5. Taylor BlauMay 11, 2023
  6. Christopher FretzMay 11, 2023
  7. Phillip WoodMay 12, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.