[PATCH v2 1/3]http: authenticate on NTLM proxies and others suppported by CuRL
- From
- Nelson Benitez Leon <nelsonjesus.benitez@seap.minhap.es>
- Date
- Mar 1, 2012, 18:19 UTC
- Message-ID
- <4F4FBDBA.8040609@seap.minhap.es>
CURLAUTH_ANY option automatically chooses the best auth method from among those the server supports, that means curl will ask the proxy and use the appropiate, and it will only do that if you are using a proxy (i.e. you've set CURLOPT_PROXY or you have http_proxy env var), also curl will not try to authenticate if you've not provided username or password in the proxy string, as told here[1]..
so, setting CURLOPT_PROXYAUTH = CURLAUTH_ANY will not affect the speed of normal curl use, only if 1) you are using a proxy and 2) your proxy requires authentication, only then curl will just make two or three roundtrips to find out the auth methods the proxy is using, that is a tiny cost compared to having the user find out the proxy auth type and set manually a specific config option to enable that type.
So as CURLAUTH_ANY provide us out-of-the-box proxy support without affecting speed, we don't want it activated manually from a config option, instead we added it automatically when a proxy is being used.
[1] https://bugzilla.redhat.com/show_bug.cgi?id=769254#c6
Signed-off-by: Nelson Benitez Leon <nbenitezl@gmail.com> --- http.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/http.c b/http.c index 0ffd79c..8ac8eb6 100644 --- a/http.c +++ b/http.c @@ -295,8 +295,10 @@ static CURL *get_curl_handle(void) if (curl_ftp_no_epsv) curl_easy_setopt(result, CURLOPT_FTP_USE_EPSV, 0); - if (curl_http_proxy) + if (curl_http_proxy) { curl_easy_setopt(result, CURLOPT_PROXY, curl_http_proxy); + curl_easy_setopt(result, CURLOPT_PROXYAUTH, CURLAUTH_ANY); + } return result; }
-- 1.7.7.6