Re: [PATCH v2] Perform cheaper connectivity check when pack is used as medium
- From
Andreas Ericsson <ae@op5.se>
- Date
- Feb 28, 2012, 15:47 UTC
- Message-ID
- <4F4CF72C.6070508@op5.se>
- In-Reply-To
- <4F4CF58A.9090502@viscovery.net>
On 02/28/2012 04:40 PM, Johannes Sixt wrote:
Show 14 quoted lines
> Am 2/28/2012 14:18, schrieb Nguyễn Thái Ngọc Duy: >> Without the patch: >> $ time git fetch file:///home/pclouds/w/git/.git >> remote: Counting objects: 125638, done. >> remote: Compressing objects: 100% (33201/33201), done. > ... >> With the patch: >> $ time git fetch file:///home/pclouds/w/git/.git >> remote: Counting objects: 125647, done. >> remote: Compressing objects: 100% (33209/33209), done. > > It is a bit irritating that the number are different when they should be > identical... >
I found it odd as well, but since the latter shows a larger object count and a shorter time, I disregarded it and considered it some evidence that he pushed this patch to that repo.
Since commit created 6 blobs, 2 trees and 1 commit object, and the latter has 9 objects more, I assume that's what happened anyways. As such, I think we can live with the small discrepancy. Also note that the latter post had slower transfer rate. That also skews the comparison somewhat, but again it's in favour of the patch.
-- Andreas Ericsson andreas.ericsson@op5.se OP5 AB www.op5.se Tel: +46 8-230225 Fax: +46 8-230231 Considering the successes of the wars on alcohol, poverty, drugs and terror, I think we should give some serious thought to declaring war on peace.