Re: [PATCH] cherry-pick -x: always insert an empty line

From: Sebastian Schuberth <sschuberth@gmail.com>
Date: Feb 23, 2012, 09:38 UTC
Message-ID: <4F460906.8030609@gmail.com>
In-Reply-To: <7vhaynp605.fsf@alter.siamese.dyndns.org>

On 19.02.2012 09:44, Junio C Hamano wrote:

Show 14 quoted lines

> If we cherry pick your commit somewhere else with "-x -s", the resulting
> commit log message would end like this:
>
>      Aside from that, even with a non-trivial commit the generated note
>      "(cherry picked from commit 555c9864971744abb558796aea28e12a1ac20839)"
>      seems abrupt when appended directly.
>
>      Cc: Eric Raible<raible@nextest.com>
>      Signed-off-by: Beat Bolli<bbolli@ewanet.ch>
>
>      (cherry picked from commit 555c9864971744abb558796aea28e12a1ac20839)
>      Signed-off-by: Frotz Xyzzy<nitfol@example.xz>
>
> which clearly is worse-looking with the extra LF you added in this patch.

Clearly? I would not say so, on the contrary. When using -s together with -x, I'd interpret this as signing off the process of cherry-picking itself, and as such, visually grouping the additional "signed-off" with the "cherry picked from" makes sense to me.

-- 
Sebastian Schuberth