Re: [PATCH] completion: --list option for git-branch

From: Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Date: Feb 16, 2012, 09:28 UTC
Message-ID: <4F3CCC4A.5010100@in.waw.pl>
In-Reply-To: <1329338218-9822-1-git-send-email-ralf.thielow@googlemail.com>

On 02/15/2012 09:36 PM, Ralf Thielow wrote:

Show 18 quoted lines

> Signed-off-by: Ralf Thielow<ralf.thielow@googlemail.com>
> ---
>   contrib/completion/git-completion.bash |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
> index d7367e9..1505cff 100755
> --- a/contrib/completion/git-completion.bash
> +++ b/contrib/completion/git-completion.bash
> @@ -1137,7 +1137,7 @@ _git_branch ()
>   		__gitcomp "
>   			--color --no-color --verbose --abbrev= --no-abbrev
>   			--track --no-track --contains --merged --no-merged
> -			--set-upstream --edit-description
> +			--set-upstream --edit-description --list
>   			"
>   		;;
>   	*)

Normally one would use just a bare 'git branch' to list branches. Why would you want to use --list in an interactive environment (as opposed to a script)? Isn't it better not to clutter the completion options with something that the user actually has not need for?

Zbyszek