Re: [PATCH] git-svn: Fix time zone in --localtime

From: Wei-Yin Chen (陳威尹) <chen.weiyin@gmail.com>
Date: Feb 12, 2012, 13:49 UTC
Message-ID: <4F37C35F.9060307@gmail.com>
In-Reply-To: <20120212081553.GA10068@dcvr.yhbt.net>

On 2012-02-12 16:15, Eric Wong wrote:

Show 12 quoted lines

> I needed the following additional change to get things working:
>
> --- a/git-svn.perl
> +++ b/git-svn.perl
> @@ -6111,7 +6111,7 @@ sub run_pager {
>
>   sub format_svn_date {
>   	my $t = shift || time;
> -	my $gmoff = get_tz($t);
> +	my $gmoff = Git::SVN::get_tz($t);
>   	return strftime("%Y-%m-%d %H:%M:%S $gmoff (%a, %d %b %Y)", localtime($t));
>   }

Sorry, my bad. This bug of missing package reference can be triggered by "git svn log", but unfortunately I didn't test this part manually. I'll learn to use the git test suite next time.

>
> If there are no objections, I'll squash this and push for Junio
> tomorrow.

Excellent. Thank you for the testing and fixing effort!