git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Breakage in master?

From
Joel C. Salomon <joelcsalomon@gmail.com>
Date
Feb 3, 2012, 13:55 UTC
Message-ID
<4F2BE759.4000902@gmail.com>
In-Reply-To
<CABPQNSZfKCTsuusPpHa2djEOeGVN9z5s_Fr+S3EaHiv7Q4Re9w@mail.gmail.com>
On 02/03/2012 07:28 AM, Erik Faye-Lund wrote:
Show 9 quoted lines
> On Thu, Feb 2, 2012 at 6:46 PM, Jeff King <peff@peff.net> wrote:
>> vsnprintf should generally never be returning -1 (it should return the
>> number of characters that would have been written). Since you're on
>> Windows, I assume you're using the replacement version in
>> compat/snprintf.c.
> 
> No. SNPRINTF_RETURNS_BOGUS is only set for the MSVC target, not for
> the MinGW target. I'm assuming that means MinGW-runtime has a sane
> vsnprintf implementation.

That doesn't sound right; MinGW defaults to linking to a fairly old version of the Windows C library (MSVCRT.dll from Visual Studio 6, IIRC). According to <http://mingw.org/wiki/C99> there exists libmingwex with some functions (especially those from <stdio.h>) replaced for Standard compatibility, but it's "far from complete". (Is msysGit using it anyway?)

--Joel
Previous: Erik Faye-LundNext: Erik Faye-Lund
Message 4 of 12 in “Breakage in master?”
  1. Erik Faye-LundFeb 2, 2012
  2. Jeff KingFeb 2, 2012
  3. Erik Faye-LundFeb 3, 2012
  4. Joel C. SalomonFeb 3, 2012
  5. Erik Faye-LundFeb 3, 2012
  6. Joel C. SalomonFeb 3, 2012
  7. Erik Faye-LundFeb 4, 2012
  8. Fwd: Breakage in master?Erik Faye-Lund, Feb 5, 2012
  9. Johannes SchindelinFeb 2, 2012
  10. Torsten BögershausenFeb 2, 2012
  11. Johannes SixtFeb 2, 2012
  12. svnpenn@gmail.comFeb 9, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.