git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Convert isatty() calls to git_isatty()

From
Johannes Sixt <j.sixt@viscovery.net>
Date
Feb 3, 2012, 09:48 UTC
Message-ID
<4F2BAD8B.1080403@viscovery.net>
In-Reply-To
<1328258101-10636-1-git-send-email-pclouds@gmail.com>
Am 2/3/2012 9:35, schrieb Nguyễn Thái Ngọc Duy:
> isatty() is used to check for interactive use cases. However if pager is
> set up, standard file handles may be redirected and istty() calls later
> on no longer reflect the original state.
So what? What's wrong with this behavior?

You converted many cases involving progress indicators. Wouldn't the new code pipe progress output to the pager where earlier it was not shown if a pager was present? That is plainly wrong: Progress output is destined only for the terminal, not for the pager.

-- Hannes
Previous: Nguyễn Thái Ngọc DuyNext: Nguyen Thai Ngoc Duy
Message 2 of 3 in “Convert isatty() calls to git_isatty()”
  1. Convert isatty() calls to git_isatty()Nguyễn Thái Ngọc Duy, Feb 3, 2012
  2. Johannes SixtFeb 3, 2012
  3. Nguyen Thai Ngoc DuyFeb 3, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.