git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/2] git-cvsexportcommit: Fix calling Perl's rel2abs() on MSYS

From
Sebastian Schuberth <sschuberth@gmail.com>
Date
Jan 11, 2012, 09:21 UTC
Message-ID
<4F0D5486.7020707@gmail.com>
In-Reply-To
<4F0D5367.1000506@gmail.com>

Due to MSYS path mangling GIT_DIR contains a Windows-style path when checked inside a Perl script even if GIT_DIR was previously set to an MSYS-style path in a shell script. So explicitly convert to an MSYS-style path before calling Perl's rel2abs() to make it work.

This fix was inspired by a very similar patch in WebKit:
http://trac.webkit.org/changeset/76255/trunk/Tools/Scripts/commit-log-editor
Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
---
 git-cvsexportcommit.perl |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/git-cvsexportcommit.perl b/git-cvsexportcommit.perl
index 39a426e..e6bf252 100755
--- a/git-cvsexportcommit.perl
+++ b/git-cvsexportcommit.perl
@@ -30,6 +30,13 @@ if ($opt_w || $opt_W) {
 		chomp($gd);
 		$ENV{GIT_DIR} = $gd;
 	}
+
+	# On MSYS, convert a Windows-style path to an MSYS-style path
+	# so that rel2abs() below works correctly.
+	if ($^O eq 'msys') {
+		$ENV{GIT_DIR} =~ s#^([[:alpha:]]):/#/$1/#;
+	}
+
 	# Make sure GIT_DIR is absolute
 	$ENV{GIT_DIR} = File::Spec->rel2abs($ENV{GIT_DIR});
 }
-- 
1.7.9.rc0.5096.g30a61
Previous: Junio C HamanoNext: Pat Thoyts
Message 4 of 5 in “Make t9200-git-cvsexportcommit.sh pass on MSYS”
  1. 0/2 Make t9200-git-cvsexportcommit.sh pass on MSYSSebastian Schuberth, Jan 11, 2012
  2. 1/2 t9200: On MSYS, do not pass Windows-style paths to CVSSebastian Schuberth, Jan 11, 2012
  3. Junio C HamanoJan 12, 2012
  4. 2/2 git-cvsexportcommit: Fix calling Perl's rel2abs() on MSYSSebastian Schuberth, Jan 11, 2012
  5. Pat ThoytsJan 11, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.