Re: [RFC/PATCH] i18n of multi-line messages

From: Chris Packham <judge.packham@gmail.com>
Date: Dec 22, 2011, 10:40 UTC
Message-ID: <4EF30907.8070101@gmail.com>
In-Reply-To: <7vaa6ldpk6.fsf@alter.siamese.dyndns.org>

Hi Junio,

On 12/22/2011 08:38 PM, Junio C Hamano wrote:

Show 17 quoted lines

> +	for (cp = buf.buf; *cp; cp = np) {
> +		np = strchrnul(cp, '\n');
> +		/*
> +		 * TRANSLATORS: the format is designed so that in RTL
> +		 * languages you could reorder and put the "prefix" at
> +		 * the end instead of the beginning of a line if you
> +		 * wanted to.
> +		 */
> +		strbuf_addf(&line,
> +			    _("%s: %.*s\n"),
> +			    prefix,
> +			    (int)(np - cp), cp);
> +		emit(&line, cb_data);
> +		strbuf_reset(&line);
> +		if (*np)
> +			np++;
> +	}

Forgive my ignorance if I've missed something, but how is this going to work for RTL languages? Translators can change the format string but they can't change the order of parameters passed to strbuf_addf.