[PATCH 4/2] grep: turn off threading for non-worktree
- From
René Scharfe <rene.scharfe@lsrfire.ath.cx>
- Date
- Dec 6, 2011, 23:01 UTC
- Message-ID
- <4EDE9ED1.8010502@lsrfire.ath.cx>
- In-Reply-To
- <4EDE9BBA.2010409@lsrfire.ath.cx>
Reading of git objects needs to be protected by an exclusive lock and cannot be parallelized. Searching the read buffers can be done in parallel, but for simple expressions threading is a net loss due to its overhead, as measured by Thomas. Turn it off unless we're searching in the worktree.
Once the object store can be read safely by multiple threads in parallel this patch should be reverted.
Signed-off-by: Rene Scharfe <rene.scharfe@lsrfire.ath.cx> --- Goes on top of my earlier patch. Could use a better commit message with your (cleaned up) performance numbers.
Documentation/git-grep.txt | 5 +++-- builtin/grep.c | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/Documentation/git-grep.txt b/Documentation/git-grep.txt index 47ac188..e981a9b 100644 --- a/Documentation/git-grep.txt +++ b/Documentation/git-grep.txt @@ -228,8 +228,9 @@ OPTIONS there is a match and with non-zero status when there isn't. --threads <n>:: - Run <n> search threads in parallel. Default is 8. This option - is ignored if git was built without support for POSIX threads. + Run <n> search threads in parallel. Default is 8 when searching + the worktree and 0 otherwise. This option is ignored if git was + built without support for POSIX threads. <tree>...:: Instead of searching tracked files in the working tree, search diff --git a/builtin/grep.c b/builtin/grep.c index 0bda900..f698642 100644 --- a/builtin/grep.c +++ b/builtin/grep.c @@ -1048,7 +1048,7 @@ int cmd_grep(int argc, const char **argv, const char *prefix) nr_threads = 0; #else if (nr_threads == -1) - nr_threads = (online_cpus() > 1) ? THREADS : 0; + nr_threads = (online_cpus() > 1 && !list.nr) ? THREADS : 0; if (nr_threads > 0) { opt.use_threads = 1;
-- 1.7.8