git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] Makefile: Add missing "sparse object" to gettext target-specific rule

From
Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Date
Nov 30, 2011, 20:43 UTC
Message-ID
<4ED69588.9020207@ramsay1.demon.co.uk>

In particular, we add gettext.sp to the target-specific rule which adds the GIT_LOCALE_PATH setting to EXTRA_CPPFLAGS, otherwise sparse complains thus:

        SP gettext.c
    gettext.c:125:25: error: undefined identifier 'GIT_LOCALE_PATH'
Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
---
Hi Avar,

If you are going to re-roll your latest i18n patch (commit 6c856c48, "i18n: add infrastructure for translating Git with gettext", 18-11-2011), could you please squash this patch into it.

Thanks!

ATB, Ramsay Jones

 Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/Makefile b/Makefile
index ac8c76d..f926b5f 100644
--- a/Makefile
+++ b/Makefile
@@ -2129,7 +2129,7 @@ config.sp config.s config.o: EXTRA_CPPFLAGS = \
 attr.sp attr.s attr.o: EXTRA_CPPFLAGS = \
 	-DETC_GITATTRIBUTES='"$(ETC_GITATTRIBUTES_SQ)"'
 
-gettext.s gettext.o: EXTRA_CPPFLAGS = \
+gettext.sp gettext.s gettext.o: EXTRA_CPPFLAGS = \
 	-DGIT_LOCALE_PATH='"$(localedir_SQ)"'
 
 http.sp http.s http.o: EXTRA_CPPFLAGS = \
-- 
1.7.7
Message 1 of 1 in “Makefile: Add missing "sparse object" to gettext target-specific rule”
  1. Makefile: Add missing "sparse object" to gettext target-specific ruleRamsay Jones, Nov 30, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.