git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/3] Compile fix for MSVC: fix poll-related macro redefines

From
Vincent van Ravesteijn <vfr@lyx.org>
Date
Nov 22, 2011, 07:30 UTC
Message-ID
<4ECB4F78.40309@lyx.org>
In-Reply-To
<4EC6978D.3020604@gmail.com>
Op 18-11-2011 18:36, Sebastian Schuberth schreef:
Show 18 quoted lines
> On 18.11.2011 17:44, Vincent van Ravesteijn wrote:
>
>> diff --git a/git-compat-util.h b/git-compat-util.h
>> index 5ef8ff7..76cbfe6 100644
>> --- a/git-compat-util.h
>> +++ b/git-compat-util.h
>> @@ -85,6 +85,7 @@
>>  #define _SGI_SOURCE 1
>>
>>  #ifdef WIN32 /* Both MinGW and MSVC */
>> +#  define _WIN32_WINNT 0x0501
>>  #define WIN32_LEAN_AND_MEAN  /* stops windows.h including winsock.h */
>>  #include<winsock2.h>
>>  #include<windows.h>
>
> It seems the indentation is wrong (does not match the surrounding 
> code) here.
>

Yes, you're right. I will reroll the patch series when there is somewhat more feedback on the series.

Vincent
Previous: Sebastian SchuberthNext: Vincent van Ravesteijn
Message 4 of 5 in “MSVC: Remove vcbuild/include/sys/poll.h”
  1. 1/3 MSVC: Remove vcbuild/include/sys/poll.hVincent van Ravesteijn, Nov 18, 2011
  2. 2/3 Compile fix for MSVC: fix poll-related macro redefinesVincent van Ravesteijn, Nov 18, 2011
  3. Sebastian SchuberthNov 18, 2011
  4. Vincent van RavesteijnNov 22, 2011
  5. 3/3 Compile fix for MSVC: Use NO_INET_PTON and NO_INET_NTOPVincent van Ravesteijn, Nov 18, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.