git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Compile fix for MSVC: Move poll.h out of sys-folder

From
Vincent van Ravesteijn <vfr@lyx.org>
Date
Nov 18, 2011, 14:42 UTC
Message-ID
<4EC66EBF.20007@lyx.org>
In-Reply-To
<CABPQNSa+ZjAMSxpBTqGW7P=v-tJTW_jdx3MO=vCpzc-z_XdHTg@mail.gmail.com>
Show 6 quoted lines
> This looks strange to me. vcbuild/include/poll.h will only prevent the
> correct header from being included, while compiling an linking against
> compat/win32/poll.[co]... That seems dangerous to me, because the
> interface might be declared differently.
>
> Instead, I think compat/vcbuild/include/poll.h should be removed,

Yes, it should just be removed. Having poll.h in the sys directory was wrong and the patch I sent was needed to make 0f77dea compile.

Your patch is indeed necessary to compile later revisions as well.
> I still can't build Junio's master,
> due to sys/resource.h missing. This comes from ebae9ff ("compat: add
> missing #include<sys/resource.h>"), and is only guarded against
> MinGW, not MSVC...

The fix for this is already in 'next' now. So, with your patch, 'next' does compile.

Vincent
Previous: Vincent van Ravesteijn
Message 5 of 5 in “Compile fix for MSVC: Move poll.h out of sys-folder”
  1. Compile fix for MSVC: Move poll.h out of sys-folderVincent van Ravesteijn, Nov 18, 2011
  2. Erik Faye-LundNov 18, 2011
  3. Erik Faye-LundNov 18, 2011
  4. Vincent van RavesteijnNov 18, 2011
  5. Vincent van RavesteijnNov 18, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.