Re: RFH: unexpected reflog behavior with --since=
- From
- Eric Raible <raible@nextest.com>
- Date
- Nov 10, 2011, 08:20 UTC
- Message-ID
- <4EBB8943.4060801@nextest.com>
- In-Reply-To
- <20111110080851.GA28342@sigill.intra.peff.net>
On 11/10/2011 12:08 AM, Jeff King wrote:
Show 7 quoted lines
>>> git log -g --format='%ct %H' |
>>> awk '{ print $2 if $1 < SOME_TIMESTAMP }'
>>
>> And then the sha would have to be fed back into git to be useful, eh?
>
> It's just illustrative. You could replace "%H" with the actual
> information you're interested in.Of course, my thinko.
Show 6 quoted lines
> The only point would be to leave "--since" to act on the commit > timestamps, so that you don't have to resort to the external grepping I > mentioned above. However, I'm not convinced anybody even cares about > that use case. > > I think the behavior you want is much more sensible.
Me too!
Show 7 quoted lines
>> Is this something you'd be willing to turn into a real patch? >> I'm certainly not qualified. > > Yes. We're in release freeze now, so I didn't even bother with sending > it to Junio. But also, I'd like to gather more opinions on whether the > design is the right thing (hopefully the implementation is Obviously > Correct. :) ).
I think it's hard to argue that the current behavior (as illustrated with my original example) makes sense. Or that your patch is overly complicated. But giving people time to chime in it definitely TRTTD.
- Eric