Breakage in master since 6d4bb3833c

When testing reference-handling performance using my refperf script [1], I noticed that there is a problem in master that I bisected down to

6d4bb3833c "fetch: verify we have everything we need before updating our ref"

When I run the following commands

======================================================= GIT=$(pwd)/git ORIG=bug-6d4bb383-repo REPO=bug-6d4bb383-clone URL=file://$(pwd)/$ORIG

$GIT init $ORIG cd $ORIG $GIT config gc.auto 0 $GIT config gc.packrefs false touch a.txt $GIT add a.txt $GIT commit -am 'Add file' cd ..

mkdir $REPO cd $REPO $GIT init $GIT remote add origin $URL $GIT fetch origin =======================================================

Then the last "git fetch origin" command gives the following output:

=======================================================
remote: Counting objects: 3, done.
remote: Total 3 (delta 0), reused 0 (delta 0)
Unpacking objects: 100% (3/3), done.
usage: git rev-list [OPTION] <commit-id>... [ -- paths... ]
  limiting output:
    --max-count=<n>
    --max-age=<epoch>
    --min-age=<epoch>
    --sparse
    --no-merges
    --min-parents=<n>
    --no-min-parents
    --max-parents=<n>
    --no-max-parents
    --remove-empty
    --all
    --branches
    --tags
    --remotes
    --stdin
    --quiet
  ordering output:
    --topo-order
    --date-order
    --reverse
  formatting output:
    --parents
    --children
    --objects | --objects-edge
    --unpacked
    --header | --pretty
    --abbrev=<n> | --no-abbrev
    --abbrev-commit
    --left-right
  special purpose:
    --bisect
    --bisect-vars
    --bisect-all
error: file:///home/mhagger/self/proj/git/git/bug-6d4bb383-repo did not
send all necessary objects

=======================================================

The same error occurs if all of the steps *except* the last one are done with a release version of git.

Michael

[1] branch "refperf" at git://github.com/mhagger/git.git