git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 12/12] is_refname_available(): reimplement using do_for_each_ref_in_array()

From
Michael Haggerty <mhagger@alum.mit.edu>
Date
Oct 20, 2011, 07:46 UTC
Message-ID
<4E9FD1C3.3090302@alum.mit.edu>
In-Reply-To
<7v4nz4bftk.fsf@alter.siamese.dyndns.org>
On 10/20/2011 03:40 AM, Junio C Hamano wrote:
> Hmm, why is this patch and only this one in the series full of whitespace
> violations? Did you use a different settings or something?

This happens rarely; I don't know why. Maybe I copy-pasted snippets from a view in an application that expanded the tabs. Maybe emacs's eliza program has achieved self-awareness and is punishing me for never having properly learned elisp.

The incorrect lines are indented with 7, not 8, spaces so "tabify" didn't help either.

I'll fix in reroll after I've received any other feedback.
Michael
-- 
Michael Haggerty
mhagger@alum.mit.edu
http://softwareswirl.blogspot.com/
Previous: Junio C HamanoNext: Michael Haggerty
Message 17 of 18 in “Use refs API more consistently”
  1. 00/12 Use refs API more consistentlymhagger@alum.mit.edu, Oct 19, 2011
  2. 01/12 Rename another local variable name -> refnamemhagger@alum.mit.edu, Oct 19, 2011
  3. 02/12 repack_without_ref(): remove temporarymhagger@alum.mit.edu, Oct 19, 2011
  4. 03/12 parse_ref_line(): add a check that the refname is properly formattedmhagger@alum.mit.edu, Oct 19, 2011
  5. 04/12 create_ref_entry(): extract function from add_ref()mhagger@alum.mit.edu, Oct 19, 2011
  6. 05/12 add_ref(): take a (struct ref_entry *) parametermhagger@alum.mit.edu, Oct 19, 2011
  7. 06/12 do_for_each_ref(): correctly terminate while processesing extra_refsmhagger@alum.mit.edu, Oct 19, 2011
  8. 07/12 do_for_each_ref_in_array(): new functionmhagger@alum.mit.edu, Oct 19, 2011
  9. 08/12 do_for_each_ref_in_arrays(): new functionmhagger@alum.mit.edu, Oct 19, 2011
  10. Junio C HamanoOct 19, 2011
  11. Michael HaggertyOct 20, 2011
  12. 09/12 repack_without_ref(): reimplement using do_for_each_ref_in_array()mhagger@alum.mit.edu, Oct 19, 2011
  13. 10/12 names_conflict(): new function, extracted from is_refname_available()mhagger@alum.mit.edu, Oct 19, 2011
  14. 11/12 names_conflict(): simplify implementationmhagger@alum.mit.edu, Oct 19, 2011
  15. 12/12 is_refname_available(): reimplement using do_for_each_ref_in_array()mhagger@alum.mit.edu, Oct 19, 2011
  16. Junio C HamanoOct 20, 2011
  17. Michael HaggertyOct 20, 2011
  18. Michael HaggertyOct 24, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.