Re: [PATCH v2 0/6] git-p4 tests, filetypes, shell metacharacters

From: Luke Diamand <luke@diamand.org>
Date: Oct 15, 2011, 20:00 UTC
Message-ID: <4E99E64C.9@diamand.org>
In-Reply-To: <20111015155358.GA29436@arf.padd.com>

On 15/10/11 16:53, Pete Wyckoff wrote:

Show 12 quoted lines

> This series of six patches has been reviewed on the mailing list
> and should be ready for inclusion.
>
> 1    - Clean up git-p4 tests, including Junio review comments
>
> 2..4 - Handle p4 filetypes better, including Chris's suggested
>         utf16 fix
>
> 5    - Fix p4 keyword parsing
>
> 6    - From Luke: avoid using the shell, so filenames with metacharacters
>         are not errantly expanded

I've just tried running the tests in parallel (master branch) and it works a treat.

You've also tidied up my earlier test cases very nicely.

There doesn't seem to be any way to cope with multiple instances of the same test running at the same time. If p4d could write its pid somewhere then something better could be done, but it doesn't.

Ack.

Thanks Luke

Show 22 quoted lines

>
> Luke Diamand (1):
>        git-p4: handle files with shell metacharacters
>
> Pete Wyckoff (5):
>        git-p4 tests: refactor and cleanup
>        git-p4: handle utf16 filetype properly
>        git-p4: recognize all p4 filetypes
>        git-p4: stop ignoring apple filetype
>        git-p4: keyword flattening fixes
>
>   contrib/fast-import/git-p4     |  287 +++++++++++++-------
>   t/lib-git-p4.sh                |   74 +++++
>   t/t9800-git-p4.sh              |  574 ++++++++++++++++++----------------------
>   t/t9801-git-p4-branch.sh       |  233 ++++++++++++++++
>   t/t9802-git-p4-filetype.sh     |  108 ++++++++
>   t/t9803-git-shell-metachars.sh |   64 +++++
>   6 files changed, 918 insertions(+), 422 deletions(-)
>   create mode 100644 t/lib-git-p4.sh
>   create mode 100755 t/t9801-git-p4-branch.sh
>   create mode 100755 t/t9802-git-p4-filetype.sh
>   create mode 100755 t/t9803-git-shell-metachars.sh