git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/3] t5403.1: simplify commit creation

From
Johannes Sixt <j.sixt@viscovery.net>
Date
Oct 12, 2011, 14:14 UTC
Message-ID
<4E95A0BF.2060003@viscovery.net>
In-Reply-To
<1318412105-13595-1-git-send-email-pclouds@gmail.com>
Am 10/12/2011 11:35, schrieb Nguyễn Thái Ngọc Duy:
Show 13 quoted lines
>  test_expect_success setup '
>  	echo Data for commit0. >a &&
>  	echo Data for commit0. >b &&
> -	git update-index --add a &&
> -	git update-index --add b &&
> -	tree0=$(git write-tree) &&
> -	commit0=$(echo setup | git commit-tree $tree0) &&
> -	git update-ref refs/heads/master $commit0 &&
> +	git add a b &&
> +	git commit -m setup &&
>  	git clone ./. clone1 &&
>  	git clone ./. clone2 &&
>  	GIT_DIR=clone2/.git git branch new2 &&

I don't think this change is necessary. It doesn't hurt to use plumbing commands here and there in the test suite to exercise them to a degree that they deserve.

-- Hannes
Previous: Nguyen Thai Ngoc DuyNext: Nguyen Thai Ngoc Duy
Message 6 of 7 in “t5403.1: simplify commit creation”
  1. 1/3 t5403.1: simplify commit creationNguyễn Thái Ngọc Duy, Oct 12, 2011
  2. 2/3 t5403: convert leading spaces to tabsNguyễn Thái Ngọc Duy, Oct 12, 2011
  3. 3/3 t5403: do not use access repos with GIT_DIR when worktree is involvedNguyễn Thái Ngọc Duy, Oct 12, 2011
  4. Junio C HamanoOct 13, 2011
  5. Nguyen Thai Ngoc DuyOct 13, 2011
  6. Johannes SixtOct 12, 2011
  7. Nguyen Thai Ngoc DuyOct 13, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.