Re: [PATCH v3 5/5] attr.c: respect core.ignorecase when matching attribute patterns

From: Michael Haggerty <mhagger@alum.mit.edu>
Date: Oct 11, 2011, 03:44 UTC
Message-ID: <4E93BBA8.6080403@alum.mit.edu>
In-Reply-To: <CA+sFfMd9exQcGfTGLJFPXG3-bq-ukn7K4m1R=LvLKqc1-jDVQw@mail.gmail.com>

On 10/10/2011 08:01 PM, Brandon Casey wrote:

Show 20 quoted lines

> On Sun, Oct 9, 2011 at 10:16 AM, Michael Haggerty <mhagger@alum.mit.edu> wrote:
> Maybe my commit message is not clear that it is describing the current
> behavior and not defining it.  Instead of
> 
>    git should only match the portion of the path below the directory
>    holding the .gitignore file according to the setting of
>    core.ignorecase.
> 
> maybe I should say
> 
>     git will currently only match the portion of the path...
> 
> I could also remove the following test from the CASE_INSENSITIVE_FS
> tests since it is really a dontcare:
> 
>    attr_check A/b/h a/b/h "-c core.ignorecase=0"
> 
> We don't care what happens when the user supplies A/b/h and a/b/h
> exists on disk when core.ignorecase=0, we only care that A/b/h is
> interpreted correctly when core.ignorecase=1.

Sounds good to me.

Thanks, Michael

-- 
Michael Haggerty
mhagger@alum.mit.edu
http://softwareswirl.blogspot.com/