git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC/PATCHv2] git-p4: handle files with shell metacharacters

From
Luke Diamand <luke@diamand.org>
Date
Sep 30, 2011, 09:06 UTC
Message-ID
<4E85867E.2050805@diamand.org>
In-Reply-To
<20110927130334.GA24327@arf.padd.com>
On 27/09/11 14:03, Pete Wyckoff wrote:
<snip>
Show 7 quoted lines
>
> If you don't mind, I'll just queue it up with the utf16 and
> test-refactor stuff I have, and send it all to Junio post-1.7.7.
> Here's how I plan to adjust your tests, given the feedback that
> Junio gave earlier and from reading other tests in t/.
>
> 		-- Pete
Pete - I've just noticed that t9803 sets P4EDITOR up for the wrong commit.

It works fine for me in my the setup I've got at home but on another setup hangs trying to run vi from within the test.

It looks like two or possibly three bugs combine with each other.
(a) my misplacement of P4EDITOR

(b) git-p4 doesn't check the return code from system(editor + fileName) at around 1018, so it just carries blithely on.

(c) "git var GIT_EDITOR" called from within the test harness gives differing results. In one setup I get "vi", in another, nothing. The tests pass in the latter case.

I'll submit a new patch series to fix (a) and (b). I'm not sure if (c) is a bug or a feature. If I get very keen I might also include a tidied up version of the recent patch for turning off the editor explicitly.

Luke
Previous: Pete Wyckoff
Message 8 of 8 in “git-p4: handle files with shell metacharacters”
  1. git-p4: handle files with shell metacharactersLuke Diamand, Sep 26, 2011
  2. git-p4: handle files with shell metacharactersLuke Diamand, Sep 26, 2011
  3. Pete WyckoffSep 26, 2011
  4. [RFC/PATCHv2] git-p4: handle files with shell metacharactersLuke Diamand, Sep 27, 2011
  5. [RFC/PATCHv2] git-p4: handle files with shell metacharactersLuke Diamand, Sep 27, 2011
  6. Luke DiamandSep 27, 2011
  7. Pete WyckoffSep 27, 2011
  8. Luke DiamandSep 30, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.