git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] gitweb: Add js=1 before an URI fragment to fix line number links

From
Johannes Sixt <j.sixt@viscovery.net>
Date
Sep 27, 2011, 06:44 UTC
Message-ID
<4E8170B3.8040205@viscovery.net>
In-Reply-To
<20110926222801.14985.qmail@stuge.se>
Am 9/27/2011 0:28, schrieb Peter Stuge:
Show 11 quoted lines
> Junio C Hamano wrote:
>> You don't have to explain these to *me* specifically as a response
>> to this thread. What I meant was that your patch should have these
>> necessary descriptions in its proposed commit log message.
> 
> IMO not so neccessary if one knows a little web and javascript, which
> is probably likely for a gitweb change..
> 
> It's a simple fix of links broken by manual URI manipulation that
> didn't consider fragments. Is the subject description really not
> enough?

No, it is not. The target audience of a commit message are people like I am. I do know a bit of Perl, and a bit of Javascript; I know how an URL is structured; I would find my way through the gitweb code if the need arises. But I am not an expert in any of these areas.

The subject alone is not sufficient because I do not know for sure what an "URI fragment" is or what role line numbers in gitweb's links play. The explanations and examples you gave in a later email were very enlightening, and they would be very helpful if *I* am forced to hack gitweb, and if I need to understand why this particular change was good.

Finding the right balance between verbosity and terseness needs practice, but to write *no* justification is practically always wrong.

-- Hannes
Previous: Peter StugeNext: Peter Stuge
Message 6 of 14 in “gitweb: Add js=1 before an URI fragment to fix line number links”
  1. gitweb: Add js=1 before an URI fragment to fix line number linksPeter Stuge, Sep 26, 2011
  2. Junio C HamanoSep 26, 2011
  3. Peter StugeSep 26, 2011
  4. Junio C HamanoSep 26, 2011
  5. Peter StugeSep 26, 2011
  6. Johannes SixtSep 27, 2011
  7. Peter StugeSep 27, 2011
  8. gitweb: Fix links to lines in blobs when javascript-actions are enabledPeter Stuge, Sep 27, 2011
  9. Junio C HamanoSep 27, 2011
  10. Peter StugeSep 28, 2011
  11. Junio C HamanoSep 27, 2011
  12. Junio C HamanoSep 26, 2011
  13. Peter StugeSep 26, 2011
  14. Jakub NarebskiSep 26, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.