git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: git-p4.skipSubmitEdit

From
Luke Diamand <luke@diamand.org>
Date
Sep 9, 2011, 17:47 UTC
Message-ID
<4E6A514C.5080200@diamand.org>
In-Reply-To
<loom.20110909T115356-849@post.gmane.org>
On 09/09/11 11:05, Vitor Antunes wrote:
Show 21 quoted lines
> L. A. Linden Levy<alevy<at>  mobitv.com>  writes:
>
>>
>> Hi All,
>>
>> I have been using git-p4 for a while and it has allowed me to completely
>> change the way I develop and still be able to use perforce which my
>> company has for its main VCS. One thing that was driving me nuts was
>> that "git p4 submit" cycles through all of my individual commits and
>> asks me if I want to change them. The way I develop I often am checking
>> in 20 to 50 different small commits each with a descriptive git comment.
>> I felt like I was doing double duty by having emacs open on every commit
>> into perforce. So I modified git-p4 to have an option to skip the
>> editor. This option coupled with git-p4.skipSubmitEditCheck will make
>> the submission non-interactive for "git p4 submit".
>
> Hi Loren,
>
> This option was already included in a recent commit. The name that was
> used is "skipSubmitEditCheck". Please make sure you are using the most
> recent version of the script.
I put that option in - glad it's of use!

That option actually just skips the check of 'did the user edit the file'. git-p4 will still go ahead and bring up the file in the editor first.

I get around this myself by setting EDITOR=/bin/true. That works for me because I'm only using it in a script.

But it's possible that an additional option would actually be useful.
Show 12 quoted lines
>
> But don't let this discourage you from submitting patches. Just makesure
> you clone git's repository and apply your patch over "maint" or "master"
> branches. For more details on how to submit patches you can read
> Documentation/SubmittingPatches.
>
> Vitor
>
> --
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous: Vitor AntunesNext: L. A. Linden Levy
Message 3 of 17 in “git-p4.skipSubmitEdit”
  1. L. A. Linden LevySep 8, 2011
  2. Vitor AntunesSep 9, 2011
  3. Luke DiamandSep 9, 2011
  4. L. A. Linden LevySep 9, 2011
  5. Luke DiamandSep 10, 2011
  6. Luke DiamandSep 12, 2011
  7. L. A. Linden LevySep 12, 2011
  8. Pete WyckoffOct 18, 2011
  9. L. A. Linden LevyOct 18, 2011
  10. Pete WyckoffOct 18, 2011
  11. Luke DiamandOct 18, 2011
  12. Pete WyckoffOct 20, 2011
  13. Michael HorowitzDec 16, 2011
  14. Luke DiamandDec 16, 2011
  15. Michael HorowitzDec 17, 2011
  16. Michael HorowitzDec 17, 2011
  17. git-p4: fix skipSubmitEdit regressionPete Wyckoff, Dec 17, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.