git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 19/19] Rename struct git_attr_check to git_attr_value

From
Michael Haggerty <mhagger@alum.mit.edu>
Date
Aug 4, 2011, 03:20 UTC
Message-ID
<4E3A0FFD.7010604@alum.mit.edu>
In-Reply-To
<7vsjpjg6k7.fsf@alter.siamese.dyndns.org>
Thanks for the good feedback.
On 08/02/2011 05:46 PM, Junio C Hamano wrote:
Show 10 quoted lines
> Michael Haggerty <mhagger@alum.mit.edu> writes:
> 
>> This described its purpose better, especially when used with
>> git_allattrs().
> 
> You probably meant s/described/describes/ but more importantly does it
> really? It is a structure used to probe into the attributes system for the
> state of various attributes on a path, and the set of possible states
> includes "there is no value" (aka unset), so it feels actively wrong to
> call it attr_value and that is why I didn't call it in the first place.

I don't think it is so unusual for a "value" object to be able to reflect the fact that the value is unset, but I can understand your point of view too. I will omit this renaming in the re-roll.

Show 10 quoted lines
> I also think git_all_attrs() (i.e. word-break underscore after "all") is
> more in line with the naming throughout the codebase, after looking at
> output from
> 
>   $ git grep -e _all'[a-z]' --and --not -e alloc -e _all_ -- '*.c'
> 
> Other than these, and the earlier comment about the copy&paste done from
> git_checkattr (which by the way should probably be "git_check_attr"), it
> seems that the series mostly consist of good clean-ups and an addition of
> a new and (probably) useful feature that is straightforward. Nice.

I thought the name was awkward, too, but I chose it to be consistent with git_checkattr(). So in the re-roll I will happily rename both functions.

Michael
-- 
Michael Haggerty
mhagger@alum.mit.edu
http://softwareswirl.blogspot.com/
Previous: Junio C Hamano
Message 24 of 24 in “Add --all option to git-check-attr”
  1. 00/19 Add --all option to git-check-attrMichael Haggerty, Jul 28, 2011
  2. 01/19 doc: Add a link from gitattributes(5) to git-check-attr(1)Michael Haggerty, Jul 28, 2011
  3. 02/19 doc: Correct git_attr() calls in example codeMichael Haggerty, Jul 28, 2011
  4. 03/19 Remove anachronism from commentMichael Haggerty, Jul 28, 2011
  5. 04/19 Disallow the empty string as an attribute nameMichael Haggerty, Jul 28, 2011
  6. 05/19 git-check-attr: Add missing "&&"Michael Haggerty, Jul 28, 2011
  7. 06/19 git-check-attr: Add tests of command-line parsingMichael Haggerty, Jul 28, 2011
  8. 07/19 Provide access to the name attribute of git_attrMichael Haggerty, Jul 28, 2011
  9. 08/19 git-check-attr: Use git_attr_name()Michael Haggerty, Jul 28, 2011
  10. 09/19 Allow querying all attributes on a fileMichael Haggerty, Jul 28, 2011
  11. Junio C HamanoAug 2, 2011
  12. Michael HaggertyAug 4, 2011
  13. 10/19 git-check-attr: Extract a function output_attr()Michael Haggerty, Jul 28, 2011
  14. 11/19 git-check-attr: Introduce a new variableMichael Haggerty, Jul 28, 2011
  15. 12/19 git-check-attr: Extract a function error_with_usage()Michael Haggerty, Jul 28, 2011
  16. 13/19 git-check-attr: Handle each error separatelyMichael Haggerty, Jul 28, 2011
  17. 14/19 git-check-attr: Process command-line args more systematicallyMichael Haggerty, Jul 28, 2011
  18. 15/19 git-check-attr: Error out if no pathnames are specifiedMichael Haggerty, Jul 28, 2011
  19. 16/19 git-check-attr: Add an --all option to show all attributesMichael Haggerty, Jul 28, 2011
  20. 17/19 git-check-attr: Drive two tests using the same raw dataMichael Haggerty, Jul 28, 2011
  21. 18/19 git-check-attr: Fix command-line handling to match docsMichael Haggerty, Jul 28, 2011
  22. 19/19 Rename struct git_attr_check to git_attr_valueMichael Haggerty, Jul 28, 2011
  23. Junio C HamanoAug 2, 2011
  24. Michael HaggertyAug 4, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.