git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/4] git-p4: one test missing config git-p4.skipSubmitEditCheck

From
Luke Diamand <luke@diamand.org>
Date
Jul 31, 2011, 10:01 UTC
Message-ID
<4E3527E6.8080303@diamand.org>
In-Reply-To
<20110731003936.GD4867@arf.padd.com>
On 31/07/11 01:39, Pete Wyckoff wrote:
> Add this missing line in one of the tests.  Otherwise, on fast
> machines, the following git-p4 commit will complain that nobody
> edited the submission message.
Thanks for fixing this.
Acked.
Show 18 quoted lines
>
> Signed-off-by: Pete Wyckoff<pw@padd.com>
> ---
>   t/t9800-git-p4.sh |    1 +
>   1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/t/t9800-git-p4.sh b/t/t9800-git-p4.sh
> index 04d8413..24a8b79 100755
> --- a/t/t9800-git-p4.sh
> +++ b/t/t9800-git-p4.sh
> @@ -207,6 +207,7 @@ test_expect_success 'refuse to preserve users without perms' '
>   	test_when_finished cleanup_git&&
>   	cd "$git"&&
>   	p4_ungrant_admin alice&&
> +	git config git-p4.skipSubmitEditCheck true&&
>   	echo "username-noperms: a change by $bobuser">>  file1&&
>   	git commit --author "$bobuser<$bobemail>" -m "perms: a change by $bobuser" file1&&
>   	! P4EDITOR=touch P4USER=alice P4PASSWD=secret "$GITP4" commit --preserve-user&&
Previous: Pete WyckoffNext: Pete Wyckoff
Message 6 of 17 in “git-p4 test cleanup, commit time change”
  1. 0/4 git-p4 test cleanup, commit time changePete Wyckoff, Jul 31, 2011
  2. 1/4 git-p4: use test_when_finished in testsPete Wyckoff, Jul 31, 2011
  3. Luke DiamandJul 31, 2011
  4. 2/4 git-p4: make tests work on p4d eval serverPete Wyckoff, Jul 31, 2011
  5. 3/4 git-p4: one test missing config git-p4.skipSubmitEditCheckPete Wyckoff, Jul 31, 2011
  6. Luke DiamandJul 31, 2011
  7. 4/4 git-p4: commit time should be most recent p4 change timePete Wyckoff, Jul 31, 2011
  8. Luke DiamandJul 31, 2011
  9. Luke DiamandJul 31, 2011
  10. Pete WyckoffJul 31, 2011
  11. Luke DiamandJul 31, 2011
  12. 0/4 git-p4 test cleanup, commit time changePete Wyckoff, Jul 31, 2011
  13. 1/4 git-p4: use test_when_finished in testsPete Wyckoff, Jul 31, 2011
  14. 2/4 git-p4: add missing && in testPete Wyckoff, Jul 31, 2011
  15. Luke DiamandJul 31, 2011
  16. 3/4 git-p4: one test missing config git-p4.skipSubmitEditCheckPete Wyckoff, Jul 31, 2011
  17. 4/4 git-p4: commit time should be most recent p4 change timePete Wyckoff, Jul 31, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.