git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC 2/2] Don't push a repository with unpushed submodules

From
Jens Lehmann <jens.lehmann@web.de>
Date
Jun 28, 2011, 22:32 UTC
Message-ID
<4E0A568E.3040202@web.de>
In-Reply-To
<4E0A506B.6040407@xiplink.com>
Am 29.06.2011 00:06, schrieb Marc Branchaud:
> First, I expect performance will be terrible in repositories with large
> and/or many submodules.  I'd go so far as to say that it's pretty much a
> show-stopper for our repository.

Large submodules won't be the problem here, but many submodules and/or many commits might cause some performance degradations here. But please notice that there is no communication with the upstream of the submodules, we only check the refs present locally. Do you still think doing some "git rev-list" invocations in your submodules will be a problem? Then please say so.

> Second, there are many times where I'm working in a submodule on branch
> "TopicA" but not in branch "TopicB".  If I've made submodule changes in
> TopicA then try to push up TopicB, won't I have have to tell push to "-f"?
> But that turns off other checks that I'd rather keep.

Nope, this patch only checks the refs to be pushed, not any others. So it will only check that all submodule commits on branch "TopicB" are pushed.

> I'd feel a lot better about this patch if the check was *off* by default and
> there was a config setting / command-line option to turn it on.

I have no objections against making that configurable, although I tend towards making this check default "on". But please feel free to test this feature and tell us if it really hinders you in your work or does cause performance degradation, we'll really appreciate the feedback!

> I also agree with Junio that this kind of verification makes more sense in a
> hook on the server side.

Hmm, but isn't that assuming that the server knows (= hosts?) both the submodule and the superproject?

Previous: Marc BranchaudNext: Marc Branchaud
Message 11 of 14 in “[RFC 0/2] push checks for unpushed remotes in submodules”
  1. Fredrik GustafssonJun 26, 2011
  2. 1/2 test whether push checks for unpushed remotes in submodulesFredrik Gustafsson, Jun 26, 2011
  3. 2/2 Don't push a repository with unpushed submodulesFredrik Gustafsson, Jun 26, 2011
  4. Junio C HamanoJun 28, 2011
  5. Heiko VoigtJun 28, 2011
  6. Junio C HamanoJun 28, 2011
  7. Fredrik GustafssonJun 28, 2011
  8. Jens LehmannJun 28, 2011
  9. Heiko VoigtJul 4, 2011
  10. Marc BranchaudJun 28, 2011
  11. Jens LehmannJun 28, 2011
  12. Marc BranchaudJun 29, 2011
  13. Fredrik GustafssonJun 28, 2011
  14. Marc BranchaudJun 29, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.